Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose some functions, structs and traits for reuse in protostar cheatcodes hint processor #3588

Merged
merged 3 commits into from
Jul 5, 2023

Conversation

abulenok
Copy link
Contributor

@abulenok abulenok commented Jul 4, 2023

We need to expose some logic to avoid code duplication

This change is Reviewable

@abulenok abulenok changed the title Expose functions, structs and traits Expose some functions, structs and traits for reuse in protostar cheatcodes hint processor Jul 4, 2023
@abulenok abulenok marked this pull request as ready for review July 4, 2023 09:37
@mkaput mkaput requested review from orizi and mkaput July 4, 2023 10:07
Copy link
Collaborator

@orizi orizi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @mkaput)

Copy link
Collaborator

@orizi orizi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @mkaput)

Copy link
Member

@mkaput mkaput left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 2 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @abulenok)

@mkaput mkaput enabled auto-merge July 5, 2023 07:46
@mkaput mkaput added this pull request to the merge queue Jul 5, 2023
Merged via the queue into starkware-libs:main with commit 573098e Jul 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants