Include ${userHome} in the supported path placeholders #3580
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkaput
approved these changes
Jul 4, 2023
There was a problem hiding this comment.
Reviewable status: 0 of 1 files reviewed, all discussions resolved
|
@spapinistarkware I think we can merge this :) |
spapinistarkware
approved these changes
Jul 5, 2023
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @jessupjn)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Support variable expansion for
${userHome}in the cairo VSCode extension.Why
My
scarbtool wasn't being picked up in most cases (I'm on a Mac) by the extension to automatically run the cairo-language-server. This is because - in various cases - macOS apps don't have access to the user's PATH by default (more information. The VSCode predefined variable expansion for${workspaceFolder}is already supported, so I figured support for the related${userHome}variable could make things easier for other mac users. Simply update your workspace settings to include the following:How
${userHome}-->process.env.HOME.This change is