Add array! macro.

[gilbens-starkware]

This change is 

[gilbens-starkware]

Reviewable status: 0 of 4 files reviewed, 1 unresolved discussion (waiting on @orizi and @spapinistarkware)

a discussion (no related file):
Change target branch.

---

[gilbens-starkware]

Reviewable status: 0 of 4 files reviewed, 1 unresolved discussion (waiting on @orizi and @spapinistarkware)

---

crates/cairo-lang-plugins/src/test_data/inline_macros line 206 at r1 (raw file):

                           _temp_array.append(2);
                           _temp_array.append(3);
                        

Trying to remove these whitespaces.

[orizi]

Reviewable status: 0 of 4 files reviewed, 2 unresolved discussions (waiting on @gilbens-starkware and @spapinistarkware)

---

crates/cairo-lang-plugins/src/plugins/inline_macros/array.rs line 17 at r1 (raw file):

        let mut expanded_code = 
            "{
                let mut _temp_array = ArrayTrait::new();

make this name worse.
?

Suggestion:

 __array_builder_macro_result___

[spapinistarkware]

Reviewed 2 of 4 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: 3 of 4 files reviewed, 3 unresolved discussions (waiting on @gilbens-starkware and @orizi)

a discussion (no related file):
Do we want square brackets? array![a,b,c]?

---

[spapinistarkware]

Reviewed 1 of 4 files at r1.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @gilbens-starkware and @orizi)

[gilbens-starkware]

Reviewable status: 1 of 4 files reviewed, 3 unresolved discussions (waiting on @orizi and @spapinistarkware)

a discussion (no related file):

Previously, spapinistarkware (Shahar Papini) wrote…

Do we want square brackets? array![a,b,c]?

Yes, I am adding it.

---

---

crates/cairo-lang-plugins/src/plugins/inline_macros/array.rs line 17 at r1 (raw file):

Previously, orizi wrote…

make this name worse.
?

Done.

[orizi]

Reviewed 2 of 3 files at r3.
Reviewable status: 3 of 4 files reviewed, 2 unresolved discussions (waiting on @spapinistarkware)

[orizi]

Reviewed 3 of 3 files at r4, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @gilbens-starkware and @spapinistarkware)

a discussion (no related file):

Previously, gilbens-starkware (Gil Ben-Shachar) wrote…

Yes, I am adding it.

adding a block for this :)

---

[gilbens-starkware]

Reviewable status: 1 of 4 files reviewed, 2 unresolved discussions (waiting on @orizi and @spapinistarkware)

a discussion (no related file):

Previously, orizi wrote…

adding a block for this :)

Done.

---

[orizi]

Reviewed 1 of 3 files at r5, all commit messages.
Reviewable status: 2 of 4 files reviewed, 5 unresolved discussions (waiting on @gilbens-starkware and @spapinistarkware)

---

crates/cairo-lang-plugins/src/plugins/inline_macros/array.rs line 24 at r6 (raw file):

                arg.as_syntax_node().get_text(db)
            ));
        }

Suggestion:

        let mut expanded_code = "{
                let mut __array_builder_macro_result__ = ArrayTrait::new();"
        .to_string();
        for arg in args {
            expanded_code.push_str(&format!(
                "\n                __array_builder_macro_result__.append({});",
                arg.as_syntax_node().get_text(db)
            ));
        }

---

crates/cairo-lang-plugins/src/plugins/inline_macros/array.rs line 29 at r6 (raw file):

                __array_builder_macro_result__
            }",
        );

Suggestion:

        expanded_code.push_str(
            "\n                __array_builder_macro_result__
            }",
        );

---

crates/cairo-lang-plugins/src/plugins/inline_macros/array.rs line 34 at r6 (raw file):

    }

    fn is_bracket_type_allowed(

doc

Code quote:

is_bracket_type_allowed(

[gilbens-starkware]

Reviewable status: 2 of 26 files reviewed, 5 unresolved discussions (waiting on @orizi and @spapinistarkware)

---

crates/cairo-lang-plugins/src/plugins/inline_macros/array.rs line 24 at r6 (raw file):

                arg.as_syntax_node().get_text(db)
            ));
        }

Done.

---

crates/cairo-lang-plugins/src/plugins/inline_macros/array.rs line 29 at r6 (raw file):

                __array_builder_macro_result__
            }",
        );

Done.

---

crates/cairo-lang-plugins/src/plugins/inline_macros/array.rs line 34 at r6 (raw file):

Previously, orizi wrote…

doc

It is docd in the trait.

[orizi]

Reviewed 1 of 23 files at r7, 23 of 23 files at r8, all commit messages.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @gilbens-starkware and @spapinistarkware)

---

crates/cairo-lang-plugins/src/plugins/inline_macros/array.rs line 19 at r8 (raw file):

        for arg in args {
            expanded_code.push_str(&format!(
                "\n                __array_builder_macro_result__.append({});",

Suggestion:

            expanded_code.push_str(&format!(
                "\n            __array_builder_macro_result__.append({});",

---

crates/cairo-lang-plugins/src/plugins/inline_macros/array.rs line 25 at r8 (raw file):

        expanded_code.push_str(
            "\n                __array_builder_macro_result__
        }",

Suggestion:

        expanded_code.push_str(
            "\n            __array_builder_macro_result__

        }",

[gilbens-starkware]

Reviewable status: 25 of 26 files reviewed, 3 unresolved discussions (waiting on @orizi and @spapinistarkware)

---

crates/cairo-lang-plugins/src/plugins/inline_macros/array.rs line 19 at r8 (raw file):

        for arg in args {
            expanded_code.push_str(&format!(
                "\n                __array_builder_macro_result__.append({});",

Done.

---

crates/cairo-lang-plugins/src/plugins/inline_macros/array.rs line 25 at r8 (raw file):

        expanded_code.push_str(
            "\n                __array_builder_macro_result__
        }",

Done.

[orizi]

Reviewed 2 of 2 files at r9, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @spapinistarkware)

[gilbens-starkware]

Resolves #3220.