-
Notifications
You must be signed in to change notification settings - Fork 581
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add starknet::get_block_number #2838
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @tensojka)
Head branch was pushed to by a user without write access
Merge queue setting changed
Tests seem to be failing. Are you working on this? |
Yes, working on this, had to do some things with a higher priority, please wait:) |
This was present in Cairo 0.10 and its absence surprised me. I can't find a good reason to omit it, so I'm proposing to add it to C1.0
@spapinistarkware Fixed the typo, now tests are passing locally, should be ready to merge. Also rebased on top of current main. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @tensojka)
This was present in Cairo 0.10 and its absence surprised me. I can't find a good reason to omit it, so I'm proposing to add it to C1.0
This change is![Reviewable](https://camo.githubusercontent.com/1541c4039185914e83657d3683ec25920c672c6c5c7ab4240ee7bff601adec0b/68747470733a2f2f72657669657761626c652e696f2f7265766965775f627574746f6e2e737667)