Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add starknet::get_block_number #2838

Merged
merged 2 commits into from
May 15, 2023
Merged

Conversation

tensojka
Copy link
Contributor

@tensojka tensojka commented Apr 16, 2023

This was present in Cairo 0.10 and its absence surprised me. I can't find a good reason to omit it, so I'm proposing to add it to C1.0


This change is Reviewable

Copy link
Contributor

@spapinistarkware spapinistarkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

:lgtm:

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @tensojka)

auto-merge was automatically disabled April 20, 2023 10:30

Head branch was pushed to by a user without write access

auto-merge was automatically disabled April 24, 2023 14:48

Merge queue setting changed

@spapinistarkware
Copy link
Contributor

Tests seem to be failing. Are you working on this?

@tensojka
Copy link
Contributor Author

Tests seem to be failing. Are you working on this?

Yes, working on this, had to do some things with a higher priority, please wait:)

tensojka and others added 2 commits May 12, 2023 14:43
This was present in Cairo 0.10 and its absence surprised me. I can't find a good reason to omit it, so I'm proposing to add it to C1.0
@tensojka
Copy link
Contributor Author

@spapinistarkware Fixed the typo, now tests are passing locally, should be ready to merge. Also rebased on top of current main.

Copy link
Collaborator

@orizi orizi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @tensojka)

@spapinistarkware spapinistarkware added this pull request to the merge queue May 15, 2023
Merged via the queue into starkware-libs:main with commit e5a5b0c May 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants