Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support auto-completion for console cmd #3521

Merged
merged 3 commits into from
Jul 10, 2022

Conversation

pause125
Copy link
Collaborator

@pause125 pause125 commented Jul 8, 2022

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: #3247

What is the new behavior?

  • In console mode, auto-completion for command, subcommand and file path is supported.

Other information

@pause125 pause125 requested a review from jolestar as a code owner July 8, 2022 04:46
@codecov
Copy link

codecov bot commented Jul 8, 2022

Codecov Report

Merging #3521 (977d105) into master (ec44d09) will decrease coverage by 0.02%.
The diff coverage is 0.96%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3521      +/-   ##
==========================================
- Coverage   29.65%   29.64%   -0.01%     
==========================================
  Files         588      589       +1     
  Lines       49567    49740     +173     
  Branches    23346    23395      +49     
==========================================
+ Hits        14694    14738      +44     
- Misses      20596    20942     +346     
+ Partials    14277    14060     -217     
Flag Coverage Δ
unittests 29.64% <0.96%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
block-relayer/src/block_relayer.rs 15.79% <ø> (ø)
cmd/indexer/src/lib.rs 66.67% <ø> (ø)
cmd/miner_client/src/solver.rs 16.67% <0.00%> (ø)
cmd/starcoin/src/chain/get_txn_proof_cmd.rs 0.00% <0.00%> (ø)
cmd/starcoin/src/state/get_proof_cmd.rs 0.00% <0.00%> (ø)
...mons/forkable-jellyfish-merkle/src/iterator/mod.rs 41.00% <ø> (-4.00%) ⬇️
commons/forkable-jellyfish-merkle/src/lib.rs 48.66% <ø> (+7.67%) ⬆️
commons/scmd/src/console.rs 0.00% <0.00%> (ø)
commons/scmd/src/context.rs 0.00% <ø> (ø)
commons/scmd/src/lib.rs 100.00% <ø> (ø)
... and 130 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 94c2ddb...977d105. Read the comment docs.

@jolestar jolestar merged commit f1e4fb2 into starcoinorg:master Jul 10, 2022
@jolestar jolestar linked an issue Jul 11, 2022 that may be closed by this pull request
@pause125 pause125 deleted the auto-completion branch August 7, 2022 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request]: Support auto-completion to console
2 participants