Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deprecated short option for TransactionOptions::max_gas_amount and Tr… #3502

Merged
merged 1 commit into from
Jul 3, 2022

Conversation

pause125
Copy link
Collaborator

@pause125 pause125 commented Jul 3, 2022

…ansactionOptions::gas_unit_price

Deprecated short option for TransactionOptions::max_gas_amount and TransactionOptions::gas_unit_price as they are not commonly used options. The short option may conflict with other commonly used options.

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Other information

@jolestar jolestar enabled auto-merge (squash) July 3, 2022 06:45
@codecov
Copy link

codecov bot commented Jul 3, 2022

Codecov Report

Merging #3502 (52b678c) into master (5cf407c) will increase coverage by 0.30%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3502      +/-   ##
==========================================
+ Coverage   31.05%   31.34%   +0.30%     
==========================================
  Files         500      500              
  Lines       46861    46861              
  Branches    22139    22139              
==========================================
+ Hits        14546    14685     +139     
- Misses      18018    18072      +54     
+ Partials    14297    14104     -193     
Flag Coverage Δ
unittests 31.34% <ø> (+0.30%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
vm/types/src/language_storage_ext.rs 37.50% <0.00%> (-12.50%) ⬇️
vm/types/src/on_chain_config/vm_config.rs 35.00% <0.00%> (-10.00%) ⬇️
...ccount_config/resources/module_upgrade_strategy.rs 34.29% <0.00%> (-8.57%) ⬇️
abi/decoder/src/lib.rs 1.58% <0.00%> (-7.87%) ⬇️
vm/types/src/token/token_value.rs 55.56% <0.00%> (-6.94%) ⬇️
rpc/api/src/contract_api.rs 11.12% <0.00%> (-5.55%) ⬇️
vm/resource-viewer/src/lib.rs 0.68% <0.00%> (-5.36%) ⬇️
config/src/helper.rs 41.18% <0.00%> (-3.92%) ⬇️
vm/transaction-builder/src/lib.rs 26.17% <0.00%> (-3.17%) ⬇️
vm/types/src/time.rs 68.75% <0.00%> (-3.12%) ⬇️
... and 97 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5cf407c...52b678c. Read the comment docs.

@jolestar jolestar merged commit ecd11a8 into starcoinorg:master Jul 3, 2022
@pause125 pause125 deleted the rm_txn_short_option branch August 7, 2022 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants