-
Notifications
You must be signed in to change notification settings - Fork 290
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add mpm deploy subcommand #3495
Conversation
我觉得可以增加一个私钥部署的选项,这样更方便,不需要使用 node 保存一个账户信息 |
这样确实要方便一些。我研究一下怎么实现。 |
以前设计 account provider 的时候考虑过环境变量私钥的 account provider 选项 #3259 |
那这个有没有实现呢? |
Done. 现在同时支持从 local-account-dir 和 secret-file 部署合约。 secret-file 用于保存私钥。 使用命令分别如下:
|
Codecov Report
@@ Coverage Diff @@
## master #3495 +/- ##
==========================================
- Coverage 31.12% 29.61% -1.51%
==========================================
Files 500 588 +88
Lines 46861 49557 +2696
Branches 22139 23332 +1193
==========================================
+ Hits 14582 14670 +88
- Misses 17965 20623 +2658
+ Partials 14314 14264 -50
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
新增从环境变量读取 private key,设置好私钥的环境变量
|
|
重新 rebase master 后提交,run benchmask 运行成功了。也许是上一次提交时,正好遇到其他 PR 被合并了,从而导致 |
benchmark 不太稳定,所以现在主要关注 build and test 这个 task. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
啥时候更新相关文档比较合适?merge 了就更新,还是等下一次 release 后再更新? |
文档可以更新了,不过文档那边 merge 之前等这边 release 一个版本。争取这周 release 一个版本吧。 |
Pull request type
Please check the type of change your PR introduces:
What is the current behavior?
Issue Number: #3462
What is the new behavior?
mpm deploy
subcommand.Other information
Draft 版本,目前已经将
starcoin dev deploy
命令的功能移植到mpm deploy
。 使用命令如下:考虑到 mpm 不应该过度依赖 starcoin node,因此只支持 rpc 链接; 因为需要签名,所以需要 account 已经 password 来unlock 账号。也许将这些 rpc 参数放到一个配置文件, 将密码参数放到一个 .secret 文件中更方便一点?
是否有其他的需求和建议? @jolestar @WGB5445