Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix the wrong logic in VMStatus::status_code() pick up move-language#197 #3481

Merged
merged 1 commit into from
Jun 23, 2022

Conversation

nkysg
Copy link
Collaborator

@nkysg nkysg commented Jun 23, 2022

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: N/A
#3355

What is the new behavior?

Other information

@jolestar jolestar linked an issue Jun 23, 2022 that may be closed by this pull request
@jolestar jolestar enabled auto-merge (squash) June 23, 2022 09:20
@jolestar jolestar merged commit 562a8f6 into master Jun 23, 2022
@jolestar jolestar deleted the status_code_panic branch June 23, 2022 09:49
@github-actions
Copy link

Benchmark for 234d23b

Click to view benchmark
Test Base PR %
accumulator_append 593.6±11.97µs 590.4±9.00µs -0.54%
block_apply/block_apply_10 264.0±0.88ms 266.0±0.51ms +0.76%
block_apply/block_apply_1000 27.0±0.02s 26.8±0.02s -0.74%
get_with_proof/db_store 36.4±0.21µs 36.3±0.30µs -0.27%
get_with_proof/mem_store 31.4±0.16µs 31.7±0.22µs +0.96%
put_and_commit/db_store/1 95.6±4.64µs 97.7±5.02µs +2.20%
put_and_commit/db_store/10 848.7±38.12µs 848.5±38.98µs -0.02%
put_and_commit/db_store/100 7.3±0.32ms 7.4±0.31ms +1.37%
put_and_commit/db_store/5 436.5±20.92µs 438.3±21.83µs +0.41%
put_and_commit/db_store/50 3.8±0.17ms 3.8±0.17ms 0.00%
put_and_commit/mem_store/1 61.5±5.62µs 61.9±6.73µs +0.65%
put_and_commit/mem_store/10 577.1±48.49µs 578.2±48.86µs +0.19%
put_and_commit/mem_store/100 5.6±0.82ms 5.7±0.83ms +1.79%
put_and_commit/mem_store/5 292.9±25.86µs 292.2±24.87µs -0.24%
put_and_commit/mem_store/50 2.8±0.18ms 2.8±0.18ms 0.00%
query_block/query_block_in(10)_times(100) 3.9±0.12ms 3.9±0.21ms 0.00%
query_block/query_block_in(10)_times(1000) 38.9±0.59ms 38.4±0.82ms -1.29%
query_block/query_block_in(10)_times(10000) 389.6±12.21ms 384.5±8.47ms -1.31%
query_block/query_block_in(1000)_times(100) 970.8±6.02µs 946.5±14.21µs -2.50%
query_block/query_block_in(1000)_times(1000) 9.7±0.04ms 9.5±0.08ms -2.06%
query_block/query_block_in(1000)_times(10000) 97.3±0.57ms 94.5±0.48ms -2.88%
storage_transaction 1096.7±356.77µs 1052.9±277.73µs -3.99%
vm/transaction_execution/1 312.2±1.08ms 313.5±6.94ms +0.42%
vm/transaction_execution/10 100.4±6.35ms 98.7±1.41ms -1.69%
vm/transaction_execution/20 91.5±0.34ms 91.6±0.30ms +0.11%
vm/transaction_execution/5 120.0±0.67ms 119.8±0.30ms -0.17%
vm/transaction_execution/50 106.1±0.50ms 105.9±0.40ms -0.19%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug Report] Debug version VM assert panic
2 participants