Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add codeowners #3474

Merged
merged 1 commit into from
Jun 20, 2022
Merged

Add codeowners #3474

merged 1 commit into from
Jun 20, 2022

Conversation

jolestar
Copy link
Member

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Other information

@codecov
Copy link

codecov bot commented Jun 19, 2022

Codecov Report

Merging #3474 (f718fd4) into master (19bfda0) will decrease coverage by 0.03%.
The diff coverage is 38.47%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3474      +/-   ##
==========================================
- Coverage   32.00%   31.98%   -0.02%     
==========================================
  Files         500      500              
  Lines       46844    46868      +24     
  Branches    21380    21372       -8     
==========================================
- Hits        14987    14985       -2     
- Misses      17588    17597       +9     
- Partials    14269    14286      +17     
Flag Coverage Δ
unittests 31.98% <38.47%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cmd/starcoin/src/cli_state.rs 48.79% <ø> (ø)
network-p2p/src/protocol/event.rs 28.58% <0.00%> (-1.42%) ⬇️
network-p2p/src/service_test.rs 27.85% <ø> (+0.32%) ⬆️
network/api/src/tests.rs 29.17% <0.00%> (+4.17%) ⬆️
network/src/worker.rs 31.75% <0.00%> (+1.11%) ⬆️
sync/src/tasks/mock.rs 47.83% <0.00%> (+1.68%) ⬆️
sync/src/tasks/tests.rs 16.13% <0.00%> (+0.25%) ⬆️
network-p2p/src/service.rs 30.09% <50.00%> (-0.68%) ⬇️
rpc/api/src/types.rs 14.24% <50.00%> (+0.09%) ⬆️
types/src/peer_info.rs 53.38% <66.67%> (+0.25%) ⬆️
... and 81 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f0d73fb...f718fd4. Read the comment docs.

@github-actions
Copy link

Benchmark for e872530

Click to view benchmark
Test Base PR %
accumulator_append 593.8±11.38µs 590.4±11.88µs -0.57%
block_apply/block_apply_10 265.4±0.94ms 264.5±0.35ms -0.34%
block_apply/block_apply_1000 27.2±0.02s 27.2±0.03s 0.00%
get_with_proof/db_store 36.3±0.21µs 36.9±0.23µs +1.65%
get_with_proof/mem_store 31.3±0.28µs 31.8±0.98µs +1.60%
put_and_commit/db_store/1 96.6±4.82µs 97.5±5.29µs +0.93%
put_and_commit/db_store/10 865.4±58.37µs 869.4±39.85µs +0.46%
put_and_commit/db_store/100 7.5±0.33ms 7.5±0.33ms 0.00%
put_and_commit/db_store/5 440.0±22.72µs 425.5±24.02µs -3.30%
put_and_commit/db_store/50 3.8±0.16ms 3.9±0.17ms +2.63%
put_and_commit/mem_store/1 62.6±6.25µs 63.1±5.80µs +0.80%
put_and_commit/mem_store/10 583.8±52.74µs 583.9±48.41µs +0.02%
put_and_commit/mem_store/100 5.7±0.87ms 5.8±0.86ms +1.75%
put_and_commit/mem_store/5 291.9±25.42µs 295.1±25.28µs +1.10%
put_and_commit/mem_store/50 2.9±0.20ms 2.9±0.19ms 0.00%
query_block/query_block_in(10)_times(100) 3.9±0.10ms 3.8±0.15ms -2.56%
query_block/query_block_in(10)_times(1000) 38.9±1.22ms 38.1±0.98ms -2.06%
query_block/query_block_in(10)_times(10000) 386.1±5.81ms 386.6±11.19ms +0.13%
query_block/query_block_in(1000)_times(100) 974.3±14.87µs 969.5±14.06µs -0.49%
query_block/query_block_in(1000)_times(1000) 9.7±0.07ms 9.7±0.32ms 0.00%
query_block/query_block_in(1000)_times(10000) 97.7±0.82ms 96.1±0.69ms -1.64%
storage_transaction 1065.3±293.25µs 1069.9±280.90µs +0.43%
vm/transaction_execution/1 314.6±0.99ms 315.6±0.67ms +0.32%
vm/transaction_execution/10 99.5±0.93ms 99.5±0.54ms 0.00%
vm/transaction_execution/20 92.2±0.16ms 92.7±0.84ms +0.54%
vm/transaction_execution/5 120.9±0.55ms 121.7±1.31ms +0.66%
vm/transaction_execution/50 106.9±0.38ms 107.1±0.86ms +0.19%

@nkysg nkysg merged commit df3911e into master Jun 20, 2022
@nkysg nkysg deleted the code_owners branch June 20, 2022 01:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants