-
Notifications
You must be signed in to change notification settings - Fork 290
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cmd/starcoin: try to generate sign file when found multisig account in txn execution process #3461
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3461 +/- ##
==========================================
- Coverage 31.95% 31.77% -0.17%
==========================================
Files 500 500
Lines 46806 46844 +38
Branches 21306 21367 +61
==========================================
- Hits 14951 14879 -72
- Misses 17693 17695 +2
- Partials 14162 14270 +108
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
看看能否在集成测试中增加一个多签测试,测试通过生成文件来收集签名和发送交易。
Pull request type
Please check the type of change your PR introduces:
What is the current behavior?
Issue Number: #3411
What is the new behavior?
For "any" txn, checking it's multisig public key or not. If it is, generate multisig file(under default dir). If not, executing it directly.
Other information