Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/starcoin: try to generate sign file when found multisig account in txn execution process #3461

Merged
merged 7 commits into from
Jun 16, 2022

Conversation

templexxx
Copy link
Contributor

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: #3411

What is the new behavior?

For "any" txn, checking it's multisig public key or not. If it is, generate multisig file(under default dir). If not, executing it directly.

Other information

@templexxx templexxx requested a review from jolestar June 12, 2022 18:45
@codecov
Copy link

codecov bot commented Jun 12, 2022

Codecov Report

Merging #3461 (1c71eb0) into master (2d55f96) will decrease coverage by 0.18%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3461      +/-   ##
==========================================
- Coverage   31.95%   31.77%   -0.17%     
==========================================
  Files         500      500              
  Lines       46806    46844      +38     
  Branches    21306    21367      +61     
==========================================
- Hits        14951    14879      -72     
- Misses      17693    17695       +2     
- Partials    14162    14270     +108     
Flag Coverage Δ
unittests 31.77% <ø> (-0.17%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cmd/starcoin/src/cli_state.rs 53.66% <ø> (ø)
vm/move-package-manager/src/lib.rs 7.70% <0.00%> (-42.30%) ⬇️
vm/natives/src/account.rs 12.50% <0.00%> (-18.75%) ⬇️
vm/natives/src/vector.rs 16.67% <0.00%> (-12.50%) ⬇️
config/src/account_vault_config.rs 52.18% <0.00%> (-8.69%) ⬇️
config/src/sync_config.rs 47.37% <0.00%> (-5.26%) ⬇️
config/src/metrics_config.rs 50.99% <0.00%> (-4.90%) ⬇️
state/state-tree/src/mock/mod.rs 43.48% <0.00%> (-4.34%) ⬇️
config/src/account_provider_config.rs 45.84% <0.00%> (-4.16%) ⬇️
vm/vm-runtime/src/metrics.rs 29.17% <0.00%> (-4.16%) ⬇️
... and 74 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2d55f96...1c71eb0. Read the comment docs.

@templexxx templexxx added the enhancement Enhancement label Jun 13, 2022
@templexxx templexxx marked this pull request as draft June 13, 2022 01:49
@templexxx templexxx changed the title cmd/starcoin: try to generate sign file when found multisig account in txn execution process (WIP) cmd/starcoin: try to generate sign file when found multisig account in txn execution process Jun 13, 2022
Copy link
Member

@jolestar jolestar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

看看能否在集成测试中增加一个多签测试,测试通过生成文件来收集签名和发送交易。

cmd/starcoin/src/cli_state.rs Show resolved Hide resolved
@jolestar jolestar marked this pull request as ready for review June 14, 2022 02:35
@jolestar jolestar merged commit f8422a0 into starcoinorg:master Jun 16, 2022
@templexxx templexxx deleted the feat.multsig branch June 17, 2022 03:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants