Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/starcoin/account: bail when pass multsig account as arg for rotat… #3454

Merged
merged 1 commit into from
Jun 10, 2022

Conversation

templexxx
Copy link
Contributor

@templexxx templexxx commented Jun 10, 2022

Close #3452

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: #3452

What is the new behavior?

Other information

@templexxx templexxx requested a review from jolestar June 10, 2022 00:16
@codecov
Copy link

codecov bot commented Jun 10, 2022

Codecov Report

Merging #3454 (331287c) into master (1c4190b) will decrease coverage by 0.51%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3454      +/-   ##
==========================================
- Coverage   32.49%   31.99%   -0.50%     
==========================================
  Files         500      500              
  Lines       46805    46805              
  Branches    21301    21301              
==========================================
- Hits        15206    14969     -237     
+ Misses      17687    17653      -34     
- Partials    13912    14183     +271     
Flag Coverage Δ
unittests 31.99% <ø> (-0.50%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
rpc/api/src/errors.rs 0.00% <0.00%> (-57.14%) ⬇️
consensus/src/dummy.rs 69.57% <0.00%> (-17.39%) ⬇️
rpc/server/src/module/mod.rs 0.00% <0.00%> (-16.66%) ⬇️
vm/types/src/contract_event.rs 50.00% <0.00%> (-16.66%) ⬇️
types/src/filter.rs 0.00% <0.00%> (-16.00%) ⬇️
vm/types/src/on_chain_config/mod.rs 43.84% <0.00%> (-10.95%) ⬇️
rpc/api/src/types/pubsub.rs 10.72% <0.00%> (-10.71%) ⬇️
vm/types/src/transaction/error.rs 3.58% <0.00%> (-10.71%) ⬇️
executor/src/block_executor.rs 33.34% <0.00%> (-8.88%) ⬇️
chain/open-block/src/lib.rs 35.10% <0.00%> (-8.60%) ⬇️
... and 82 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1c4190b...331287c. Read the comment docs.

@templexxx templexxx self-assigned this Jun 10, 2022
@jolestar jolestar merged commit 1941e63 into starcoinorg:master Jun 10, 2022
@templexxx templexxx deleted the feat.multsigrotate branch June 10, 2022 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request] Should only supports non-multisig account for starcoin/account/rotate_auth_key_cmd
2 participants