Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modify sync blocks timing #3386

Merged
merged 1 commit into from
May 6, 2022
Merged

modify sync blocks timing #3386

merged 1 commit into from
May 6, 2022

Conversation

yourmoonlight
Copy link
Collaborator

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the new behavior?

Once a day is not enough for sync blocks task while block gap is set to 10k.
Twice a day should be ok.

@yourmoonlight yourmoonlight requested review from jolestar and sanlee42 May 6, 2022 05:41
@codecov
Copy link

codecov bot commented May 6, 2022

Codecov Report

Merging #3386 (c96d54e) into master (bef5e75) will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3386      +/-   ##
==========================================
+ Coverage   32.30%   32.32%   +0.02%     
==========================================
  Files         500      500              
  Lines       46815    46815              
  Branches    21314    21314              
==========================================
+ Hits        15117    15126       +9     
- Misses      17581    17687     +106     
+ Partials    14117    14002     -115     
Flag Coverage Δ
unittests 32.32% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
config/src/network_config.rs 52.27% <ø> (-0.41%) ⬇️
vm/types/src/language_storage_ext.rs 37.50% <0.00%> (-12.50%) ⬇️
vm/types/src/on_chain_config/vm_config.rs 35.00% <0.00%> (-11.66%) ⬇️
consensus/src/dummy.rs 69.57% <0.00%> (-8.69%) ⬇️
...ccount_config/resources/module_upgrade_strategy.rs 34.29% <0.00%> (-8.57%) ⬇️
abi/decoder/src/lib.rs 1.58% <0.00%> (-7.87%) ⬇️
config/src/helper.rs 47.06% <0.00%> (-5.88%) ⬇️
rpc/api/src/contract_api.rs 11.77% <0.00%> (-5.88%) ⬇️
vm/resource-viewer/src/lib.rs 0.66% <0.00%> (-5.26%) ⬇️
...mons/forkable-jellyfish-merkle/src/iterator/mod.rs 42.50% <0.00%> (-4.00%) ⬇️
... and 75 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e0ec500...c96d54e. Read the comment docs.

@github-actions
Copy link

github-actions bot commented May 6, 2022

Benchmark for 932d8aa

Click to view benchmark
Test Base PR %
accumulator_append 585.8±11.06µs 589.5±10.71µs +0.63%
block_apply/block_apply_10 263.8±0.66ms 267.0±0.81ms +1.21%
block_apply/block_apply_1000 26.9±0.02s 27.1±0.06s +0.74%
get_with_proof/db_store 38.2±0.38µs 36.1±0.25µs -5.50%
get_with_proof/mem_store 33.0±0.21µs 31.5±0.25µs -4.55%
put_and_commit/db_store/1 96.0±5.63µs 95.4±4.87µs -0.62%
put_and_commit/db_store/10 859.2±40.53µs 854.0±39.34µs -0.61%
put_and_commit/db_store/100 7.4±0.33ms 7.4±0.32ms 0.00%
put_and_commit/db_store/5 440.7±22.64µs 435.5±21.87µs -1.18%
put_and_commit/db_store/50 3.8±0.17ms 3.8±0.17ms 0.00%
put_and_commit/mem_store/1 62.3±5.63µs 61.9±5.65µs -0.64%
put_and_commit/mem_store/10 581.1±46.53µs 575.6±46.11µs -0.95%
put_and_commit/mem_store/100 5.7±0.81ms 5.7±0.85ms 0.00%
put_and_commit/mem_store/5 296.3±24.20µs 291.1±24.69µs -1.75%
put_and_commit/mem_store/50 2.9±0.18ms 2.9±0.19ms 0.00%
query_block/query_block_in(10)_times(100) 3.9±0.16ms 3.9±0.06ms 0.00%
query_block/query_block_in(10)_times(1000) 38.7±1.22ms 39.2±0.40ms +1.29%
query_block/query_block_in(10)_times(10000) 392.3±6.50ms 384.4±7.40ms -2.01%
query_block/query_block_in(1000)_times(100) 944.2±4.13µs 968.4±6.27µs +2.56%
query_block/query_block_in(1000)_times(1000) 9.5±0.07ms 9.6±0.05ms +1.05%
query_block/query_block_in(1000)_times(10000) 94.6±1.05ms 97.4±0.39ms +2.96%
storage_transaction 1060.4±301.25µs 1064.4±305.47µs +0.38%
vm/transaction_execution/1 313.6±0.45ms 313.1±0.56ms -0.16%
vm/transaction_execution/10 99.3±0.83ms 100.2±2.82ms +0.91%
vm/transaction_execution/20 92.9±1.63ms 92.3±0.30ms -0.65%
vm/transaction_execution/5 121.2±0.93ms 120.9±0.75ms -0.25%
vm/transaction_execution/50 107.5±1.14ms 106.6±0.29ms -0.84%

@jolestar jolestar merged commit bb883ab into master May 6, 2022
@jolestar jolestar deleted the sync_cron_timing branch May 6, 2022 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants