Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mpm] change the spectest to integration-test #3334

Merged
merged 1 commit into from
Apr 13, 2022
Merged

Conversation

jolestar
Copy link
Member

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: resolve #3308 fix #3229

What is the new behavior?

Use mpm integration-test to replace mpm spectest, and use the tests as tests files dir.
The mpm spectest command is still available for compatibility.

Other information

@jolestar jolestar requested review from nanne007 and LemonHX April 12, 2022 06:25
@codecov
Copy link

codecov bot commented Apr 12, 2022

Codecov Report

Merging #3334 (7ee4434) into master (78db4c7) will increase coverage by 0.14%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3334      +/-   ##
==========================================
+ Coverage   32.18%   32.32%   +0.14%     
==========================================
  Files         500      500              
  Lines       46785    46785              
  Branches    21228    21228              
==========================================
+ Hits        15054    15118      +64     
+ Misses      17676    17659      -17     
+ Partials    14055    14008      -47     
Flag Coverage Δ
unittests 32.32% <100.00%> (+0.14%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
vm/move-package-manager/src/lib.rs 50.00% <100.00%> (ø)
consensus/src/consensus.rs 58.74% <0.00%> (-4.76%) ⬇️
...mons/forkable-jellyfish-merkle/src/iterator/mod.rs 40.50% <0.00%> (-4.50%) ⬇️
state/state-tree/src/mock/mod.rs 43.48% <0.00%> (-4.34%) ⬇️
chain/src/verifier/mod.rs 39.85% <0.00%> (-3.12%) ⬇️
sync/src/block_connector/write_block_chain.rs 30.00% <0.00%> (-1.92%) ⬇️
types/src/block.rs 58.79% <0.00%> (-1.80%) ⬇️
sync/src/block_connector/test_write_block_chain.rs 32.56% <0.00%> (-1.55%) ⬇️
...ns/forkable-jellyfish-merkle/src/tree_cache/mod.rs 73.81% <0.00%> (-1.19%) ⬇️
consensus/src/difficulty.rs 38.83% <0.00%> (-1.17%) ⬇️
... and 57 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 78db4c7...7ee4434. Read the comment docs.

@github-actions
Copy link

Benchmark for eb8115e

Click to view benchmark
Test Base PR %
accumulator_append 587.9±11.56µs 588.8±9.42µs +0.15%
block_apply/block_apply_10 265.2±0.66ms 266.8±0.62ms +0.60%
block_apply/block_apply_1000 27.1±0.05s 27.2±0.02s +0.37%
get_with_proof/db_store 36.0±0.39µs 36.2±0.33µs +0.56%
get_with_proof/mem_store 31.3±0.29µs 31.4±0.28µs +0.32%
put_and_commit/db_store/1 94.2±4.78µs 94.1±4.97µs -0.11%
put_and_commit/db_store/10 839.9±40.19µs 849.4±39.73µs +1.13%
put_and_commit/db_store/100 7.2±0.29ms 7.3±0.30ms +1.39%
put_and_commit/db_store/5 431.9±22.26µs 435.2±23.18µs +0.76%
put_and_commit/db_store/50 3.8±0.18ms 3.8±0.16ms 0.00%
put_and_commit/mem_store/1 61.0±5.76µs 61.3±5.44µs +0.49%
put_and_commit/mem_store/10 572.2±50.26µs 576.0±51.04µs +0.66%
put_and_commit/mem_store/100 5.6±0.89ms 5.7±0.81ms +1.79%
put_and_commit/mem_store/5 287.0±24.24µs 288.5±24.46µs +0.52%
put_and_commit/mem_store/50 2.8±0.18ms 2.8±0.18ms 0.00%
query_block/query_block_in(10)_times(100) 3.9±0.19ms 3.8±0.05ms -2.56%
query_block/query_block_in(10)_times(1000) 38.6±0.69ms 38.7±0.58ms +0.26%
query_block/query_block_in(10)_times(10000) 386.4±6.34ms 384.0±6.51ms -0.62%
query_block/query_block_in(1000)_times(100) 958.1±7.82µs 960.9±11.37µs +0.29%
query_block/query_block_in(1000)_times(1000) 9.6±0.08ms 9.6±0.07ms 0.00%
query_block/query_block_in(1000)_times(10000) 95.3±0.33ms 96.8±0.81ms +1.57%
storage_transaction 1071.1±323.54µs 1061.6±306.96µs -0.89%
vm/transaction_execution/1 317.0±5.35ms 315.7±1.46ms -0.41%
vm/transaction_execution/10 98.8±0.30ms 98.9±0.30ms +0.10%
vm/transaction_execution/20 90.8±0.15ms 91.6±1.44ms +0.88%
vm/transaction_execution/5 121.1±0.24ms 121.3±0.75ms +0.17%
vm/transaction_execution/50 102.6±0.16ms 102.7±0.39ms +0.10%

@jolestar jolestar merged commit d07e82d into master Apr 13, 2022
@jolestar jolestar deleted the mpm_integration_test branch April 13, 2022 00:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[mpm] Rename spectest move-package-manager panicked in spectest command
2 participants