Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update actix to version 0.13 #3271

Merged
merged 1 commit into from
Mar 24, 2022
Merged

Conversation

LemonHX
Copy link
Member

@LemonHX LemonHX commented Mar 8, 2022

Signed-off-by: LemonHX [email protected]

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Other information

Copy link
Member Author

@LemonHX LemonHX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

self review

cmd/miner_client/src/main.rs Outdated Show resolved Hide resolved
commons/service-registry/tests/panic.rs Outdated Show resolved Hide resolved
commons/stest/stest-macro/src/lib.rs Outdated Show resolved Hide resolved
rpc/client/src/lib.rs Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Mar 8, 2022

Codecov Report

Merging #3271 (13b0226) into master (982b74e) will decrease coverage by 0.07%.
The diff coverage is 17.86%.

❗ Current head 13b0226 differs from pull request most recent head 3b8e0d8. Consider uploading reports for the commit 3b8e0d8 to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3271      +/-   ##
==========================================
- Coverage   32.02%   31.95%   -0.06%     
==========================================
  Files         500      500              
  Lines       46274    46280       +6     
  Branches    20916    20932      +16     
==========================================
- Hits        14814    14786      -28     
+ Misses      17662    17609      -53     
- Partials    13798    13885      +87     
Flag Coverage Δ
unittests 31.95% <17.86%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
account/provider/src/provider/mod.rs 10.00% <0.00%> (ø)
account/service/src/service.rs 17.47% <ø> (ø)
cmd/indexer/src/es_sinker.rs 0.00% <0.00%> (ø)
commons/metrics/src/metric_server.rs 0.00% <ø> (ø)
commons/service-registry/src/bus/tests.rs 2.78% <0.00%> (ø)
commons/service-registry/src/service_registry.rs 42.05% <0.00%> (-0.60%) ⬇️
commons/stest/src/lib.rs 40.00% <0.00%> (+0.98%) ⬆️
commons/stest/stest-macro/src/lib.rs 28.58% <ø> (ø)
node/src/lib.rs 18.05% <0.00%> (ø)
txpool/src/test.rs 15.07% <0.00%> (ø)
... and 101 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 982b74e...3b8e0d8. Read the comment docs.

@jolestar jolestar requested review from sanlee42 and jolestar March 8, 2022 09:47
@jolestar jolestar linked an issue Mar 9, 2022 that may be closed by this pull request
@LemonHX LemonHX force-pushed the update_actix branch 2 times, most recently from 6ed40dd to a8d5d61 Compare March 21, 2022 12:09
update tokio to version 1
rewrite stest
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[dev] Upgrade actix to 0.13.0
3 participants