-
Notifications
You must be signed in to change notification settings - Fork 290
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update clap to version 3 #3252
update clap to version 3 #3252
Conversation
run
to ensure the starcoin CLI command arguments is compatible |
disable devtools/x will cause |
Codecov Report
@@ Coverage Diff @@
## master #3252 +/- ##
==========================================
+ Coverage 32.07% 32.11% +0.05%
==========================================
Files 500 500
Lines 46787 46785 -2
Branches 21313 21228 -85
==========================================
+ Hits 15003 15022 +19
- Misses 17611 17916 +305
+ Partials 14173 13847 -326
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
@LemonHX 运行一下这个测试,检查一下命令行参数的兼容性。我在本地运行了一下这个测试,有编译错误。
这个测试本来应该自动运行的,但不知什么原因会卡住 ci,所以暂时没有自动运行。 |
ccf9f16
to
0e877ab
Compare
and fix windows compatibility
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bors +1
bors +1 |
close #3251
Pull request type
Please check the type of change your PR introduces:
What is the current behavior?
Issue Number: #3251
What is the new behavior?
Other information