Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update clap to version 3 #3252

Merged
merged 5 commits into from
Apr 11, 2022
Merged

update clap to version 3 #3252

merged 5 commits into from
Apr 11, 2022

Conversation

LemonHX
Copy link
Member

@LemonHX LemonHX commented Feb 27, 2022

close #3251

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: #3251

What is the new behavior?

Other information

@jolestar
Copy link
Member

run

cargo test --test integration -- -e cmd

to ensure the starcoin CLI command arguments is compatible

@jolestar
Copy link
Member

disable devtools/x will cause cargo xtest to not work properly, and the CI failed.

@codecov
Copy link

codecov bot commented Apr 1, 2022

Codecov Report

Merging #3252 (2864eaf) into master (b0eaa9e) will increase coverage by 0.05%.
The diff coverage is 5.67%.

❗ Current head 2864eaf differs from pull request most recent head f587ec5. Consider uploading reports for the commit f587ec5 to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3252      +/-   ##
==========================================
+ Coverage   32.07%   32.11%   +0.05%     
==========================================
  Files         500      500              
  Lines       46787    46785       -2     
  Branches    21313    21228      -85     
==========================================
+ Hits        15003    15022      +19     
- Misses      17611    17916     +305     
+ Partials    14173    13847     -326     
Flag Coverage Δ
unittests 32.11% <5.67%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
chain/src/verifier/mod.rs 36.72% <0.00%> (-8.19%) ⬇️
cmd/starcoin/src/lib.rs 100.00% <ø> (ø)
commons/accumulator/src/accumulator_test.rs 25.90% <0.00%> (-0.07%) ⬇️
commons/scmd/src/action.rs 0.00% <0.00%> (ø)
commons/scmd/src/context.rs 0.00% <ø> (ø)
commons/scmd/src/error.rs 0.00% <0.00%> (ø)
commons/scmd/src/result.rs 0.00% <0.00%> (ø)
config/src/account_provider_config.rs 50.00% <0.00%> (-2.17%) ⬇️
config/src/metrics_config.rs 55.89% <0.00%> (+1.97%) ⬆️
config/src/network_config.rs 52.05% <0.00%> (-0.21%) ⬇️
... and 137 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b0eaa9e...f587ec5. Read the comment docs.

config/src/lib.rs Outdated Show resolved Hide resolved
vm/move-package-manager/src/main.rs Outdated Show resolved Hide resolved
vm/starcoin-transactional-test-harness/src/lib.rs Outdated Show resolved Hide resolved
@jolestar jolestar requested a review from nanne007 April 1, 2022 03:54
@jolestar
Copy link
Member

jolestar commented Apr 1, 2022

run

cargo test --test integration -- -e cmd

to ensure the starcoin CLI command arguments is compatible

@LemonHX 运行一下这个测试,检查一下命令行参数的兼容性。我在本地运行了一下这个测试,有编译错误。

error[E0432]: unresolved import `starcoin_account_provider`
  --> testsuite/tests/steps/cmd.rs:11:5
   |
11 | use starcoin_account_provider::ProviderFactory;
   |     ^^^^^^^^^^^^^^^^^^^^^^^^^ use of undeclared crate or module `starcoin_account_provider`
   |
help: there is a crate or module with a similar name
   |
11 | use starcoin_account_api::ProviderFactory;
   |     ~~~~~~~~~~~~~~~~~~~~

这个测试本来应该自动运行的,但不知什么原因会卡住 ci,所以暂时没有自动运行。

@LemonHX LemonHX requested a review from jolestar April 1, 2022 06:53
@LemonHX LemonHX force-pushed the clap3 branch 3 times, most recently from ccf9f16 to 0e877ab Compare April 7, 2022 01:37
and fix windows compatibility
Copy link
Member

@jolestar jolestar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors +1

@LemonHX
Copy link
Member Author

LemonHX commented Apr 11, 2022

bors +1

@LemonHX LemonHX merged commit 32628dd into starcoinorg:master Apr 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dev: update clap to v3
2 participants