Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[rpc] Do not raise error when decode resource or resolve module failed #3206

Merged
merged 2 commits into from
Feb 13, 2022

Conversation

jolestar
Copy link
Member

if the resource format is not compatible with the Struct, just ignore the error, and do not return decoded resource.

@jolestar jolestar requested review from nanne007 and welbon February 11, 2022 07:37
@jolestar
Copy link
Member Author

part of #3199

@codecov
Copy link

codecov bot commented Feb 11, 2022

Codecov Report

Merging #3206 (97450c9) into master (78046e9) will decrease coverage by 0.20%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3206      +/-   ##
==========================================
- Coverage   32.13%   31.93%   -0.19%     
==========================================
  Files         503      503              
  Lines       46328    46326       -2     
  Branches    21261    21261              
==========================================
- Hits        14881    14789      -92     
+ Misses      17448    17419      -29     
- Partials    13999    14118     +119     
Flag Coverage Δ
unittests 31.93% <0.00%> (-0.19%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
rpc/server/src/module/state_rpc.rs 5.69% <0.00%> (+0.07%) ⬆️
vm/natives/src/account.rs 12.50% <0.00%> (-12.50%) ⬇️
executor/src/block_executor.rs 21.28% <0.00%> (-10.63%) ⬇️
node/src/network_service_factory.rs 20.84% <0.00%> (-8.33%) ⬇️
vm/types/src/on_chain_config/mod.rs 41.10% <0.00%> (-6.84%) ⬇️
vm/natives/src/token.rs 26.67% <0.00%> (-6.66%) ⬇️
...s/forkable-jellyfish-merkle/src/mock_tree_store.rs 33.90% <0.00%> (-5.08%) ⬇️
vm/types/src/transaction_metadata.rs 61.20% <0.00%> (-4.47%) ⬇️
executor/src/executor.rs 50.00% <0.00%> (-4.16%) ⬇️
network/src/worker.rs 30.65% <0.00%> (-3.22%) ⬇️
... and 64 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 78046e9...97450c9. Read the comment docs.

@jolestar jolestar merged commit de9150a into master Feb 13, 2022
@jolestar jolestar deleted the state_decode branch February 13, 2022 03:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants