Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cmd] state list command decode resource at local with remove state reader #3200

Merged
merged 1 commit into from
Feb 10, 2022

Conversation

jolestar
Copy link
Member

@jolestar jolestar commented Feb 8, 2022

[cmd] state list command decode resource at local with remove state reader

  1. reduce the remote node api cost
  2. for debugging invalid resource The requirement of upgrading compatibility checking tools #3199

@jolestar jolestar requested a review from nanne007 February 8, 2022 10:56
@codecov
Copy link

codecov bot commented Feb 8, 2022

Codecov Report

Merging #3200 (4bac01a) into master (0a3c36f) will increase coverage by 0.10%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3200      +/-   ##
==========================================
+ Coverage   32.04%   32.13%   +0.10%     
==========================================
  Files         503      503              
  Lines       46305    46305              
  Branches    21240    21241       +1     
==========================================
+ Hits        14834    14876      +42     
- Misses      17305    17436     +131     
+ Partials    14166    13993     -173     
Flag Coverage Δ
unittests 32.13% <ø> (+0.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
network/src/worker.rs 30.65% <0.00%> (-17.74%) ⬇️
vm/types/src/language_storage_ext.rs 37.50% <0.00%> (-12.50%) ⬇️
vm/types/src/on_chain_config/vm_config.rs 35.00% <0.00%> (-11.66%) ⬇️
...ccount_config/resources/module_upgrade_strategy.rs 34.29% <0.00%> (-8.57%) ⬇️
abi/decoder/src/lib.rs 1.58% <0.00%> (-7.87%) ⬇️
rpc/api/src/contract_api.rs 11.77% <0.00%> (-5.88%) ⬇️
vm/resource-viewer/src/lib.rs 0.66% <0.00%> (-5.26%) ⬇️
vm/types/src/token/token_code.rs 34.12% <0.00%> (-4.70%) ⬇️
rpc/server/src/module/contract_rpc.rs 3.71% <0.00%> (-3.70%) ⬇️
vm/resource-viewer/src/fat_type.rs 0.00% <0.00%> (-3.03%) ⬇️
... and 74 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0a3c36f...4bac01a. Read the comment docs.

@jolestar jolestar merged commit afffc4d into master Feb 10, 2022
@jolestar jolestar deleted the state_list_cmd branch February 10, 2022 01:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants