Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update write buffer config #3198

Merged
merged 16 commits into from
Feb 8, 2022
Merged

update write buffer config #3198

merged 16 commits into from
Feb 8, 2022

Conversation

nkysg
Copy link
Collaborator

@nkysg nkysg commented Feb 8, 2022

No description provided.

@codecov
Copy link

codecov bot commented Feb 8, 2022

Codecov Report

Merging #3198 (7e44b6d) into master (0a3c36f) will decrease coverage by 0.18%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3198      +/-   ##
==========================================
- Coverage   32.04%   31.87%   -0.17%     
==========================================
  Files         503      503              
  Lines       46305    46307       +2     
  Branches    21240    21242       +2     
==========================================
- Hits        14834    14755      -79     
- Misses      17305    17460     +155     
+ Partials    14166    14092      -74     
Flag Coverage Δ
unittests 31.87% <50.00%> (-0.17%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
storage/src/db_storage/mod.rs 48.33% <50.00%> (+0.99%) ⬆️
network/src/worker.rs 30.65% <0.00%> (-17.74%) ⬇️
vm/types/src/language_storage_ext.rs 37.50% <0.00%> (-12.50%) ⬇️
vm/types/src/on_chain_config/vm_config.rs 35.00% <0.00%> (-11.66%) ⬇️
vm/types/src/transaction_metadata.rs 56.72% <0.00%> (-8.95%) ⬇️
...ccount_config/resources/module_upgrade_strategy.rs 34.29% <0.00%> (-8.57%) ⬇️
abi/decoder/src/lib.rs 1.58% <0.00%> (-7.87%) ⬇️
network-rpc/core/src/lib.rs 24.00% <0.00%> (-6.00%) ⬇️
rpc/api/src/contract_api.rs 11.77% <0.00%> (-5.88%) ⬇️
vm/resource-viewer/src/lib.rs 0.66% <0.00%> (-5.26%) ⬇️
... and 71 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0a3c36f...7e44b6d. Read the comment docs.

@github-actions
Copy link

github-actions bot commented Feb 8, 2022

Benchmark for 590c976

Click to view benchmark
Test Base PR %
accumulator_append 591.4±13.93µs 594.0±12.77µs +0.44%
block_apply/block_apply_10 260.1±1.60ms 258.6±0.90ms -0.58%
block_apply/block_apply_1000 26.5±0.02s 26.4±0.04s -0.38%
get_with_proof/db_store 36.2±0.50µs 36.0±0.30µs -0.55%
get_with_proof/mem_store 31.2±0.31µs 31.1±0.28µs -0.32%
put_and_commit/db_store/1 95.3±4.68µs 95.0±4.76µs -0.31%
put_and_commit/db_store/10 852.9±44.52µs 847.4±39.93µs -0.64%
put_and_commit/db_store/100 7.3±0.32ms 7.2±0.31ms -1.37%
put_and_commit/db_store/5 433.8±23.86µs 431.4±21.67µs -0.55%
put_and_commit/db_store/50 3.8±0.16ms 3.8±0.18ms 0.00%
put_and_commit/mem_store/1 61.1±5.43µs 61.0±5.47µs -0.16%
put_and_commit/mem_store/10 568.4±45.23µs 570.2±46.70µs +0.32%
put_and_commit/mem_store/100 5.6±0.80ms 5.6±0.81ms 0.00%
put_and_commit/mem_store/5 291.2±24.90µs 287.5±24.65µs -1.27%
put_and_commit/mem_store/50 2.8±0.18ms 2.8±0.18ms 0.00%
query_block/query_block_in(10)_times(100) 3.9±0.09ms 3.8±0.09ms -2.56%
query_block/query_block_in(10)_times(1000) 39.0±0.60ms 38.5±0.91ms -1.28%
query_block/query_block_in(10)_times(10000) 384.8±8.52ms 393.3±7.05ms +2.21%
query_block/query_block_in(1000)_times(100) 948.3±8.04µs 958.7±6.75µs +1.10%
query_block/query_block_in(1000)_times(1000) 9.5±0.11ms 9.5±0.07ms 0.00%
query_block/query_block_in(1000)_times(10000) 94.9±0.79ms 95.7±0.78ms +0.84%
storage_transaction 1234.0±361.72µs 1050.2±289.79µs -14.89%
vm/transaction_execution/1 306.7±1.57ms 306.8±1.20ms +0.03%
vm/transaction_execution/10 96.7±0.81ms 97.0±1.11ms +0.31%
vm/transaction_execution/20 89.2±0.32ms 89.6±0.70ms +0.45%
vm/transaction_execution/5 118.5±1.82ms 118.1±0.40ms -0.34%
vm/transaction_execution/50 101.5±1.41ms 101.6±1.29ms +0.10%

@nkysg nkysg requested a review from jolestar February 8, 2022 12:05
@jolestar jolestar merged commit d4fa1b6 into master Feb 8, 2022
@jolestar jolestar deleted the db_config branch February 8, 2022 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants