Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bench block transaction #3141

Merged
merged 13 commits into from
Jan 17, 2022
Merged

Bench block transaction #3141

merged 13 commits into from
Jan 17, 2022

Conversation

nkysg
Copy link
Collaborator

@nkysg nkysg commented Jan 10, 2022

No description provided.

@nkysg nkysg marked this pull request as draft January 10, 2022 13:32
@nkysg nkysg marked this pull request as ready for review January 12, 2022 15:32
@nkysg nkysg requested a review from jolestar January 12, 2022 15:33
Copy link
Member

@jolestar jolestar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Jan 16, 2022

Codecov Report

Merging #3141 (0027638) into master (9635a54) will increase coverage by 0.57%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3141      +/-   ##
==========================================
+ Coverage   31.84%   32.41%   +0.57%     
==========================================
  Files         503      503              
  Lines       46260    46274      +14     
  Branches    21171    21174       +3     
==========================================
+ Hits        14729    14993     +264     
+ Misses      17480    17454      -26     
+ Partials    14051    13827     -224     
Flag Coverage Δ
unittests 32.41% <0.00%> (+0.57%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
account/api/src/types.rs 47.23% <0.00%> (-4.29%) ⬇️
types/src/account.rs 7.95% <0.00%> (ø)
vm/transaction-builder/src/lib.rs 27.88% <0.00%> (+0.74%) ⬆️
consensus/src/consensus.rs 49.21% <0.00%> (-9.52%) ⬇️
txpool/src/pool/listener/tests.rs 10.91% <0.00%> (-3.63%) ⬇️
network-p2p/src/peer_info.rs 45.66% <0.00%> (-2.71%) ⬇️
account/src/account_storage.rs 50.75% <0.00%> (-1.99%) ⬇️
config/src/available_port.rs 50.00% <0.00%> (-1.92%) ⬇️
types/src/startup_info.rs 64.23% <0.00%> (-1.83%) ⬇️
...s/forkable-jellyfish-merkle/src/mock_tree_store.rs 32.21% <0.00%> (-1.69%) ⬇️
... and 76 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9635a54...0027638. Read the comment docs.

@jolestar jolestar merged commit a76beb8 into master Jan 17, 2022
@jolestar jolestar deleted the bench_block_transaction branch January 17, 2022 00:49
@jolestar
Copy link
Member

@nkysg 从 master 合并的时候尽量 rebase,不要 merge.

@nkysg
Copy link
Collaborator Author

nkysg commented Jan 17, 2022

@nkysg 从 master 合并的时候尽量 rebase,不要 merge.

OK

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants