Feat/add mobile keyring bridge flat version #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-keyring to successfully solve the metamask-mobile not able to resovle all the module under the subdirectory during build process.
dawnseeker8
merged commit d6b8138
into
feat/add-mobile-keyring-bridge
11 of 15 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge the backup flat version to original branch after mobile testing is ok.
React native seems can't discover the module under
ledger-mobile-bridgefolder in runtime, and cause engine.ts failed to intiailise. the only way currently to make it work is to move all classes inledger-moible-bridgefolder to top level.