Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Enable pre-commit CI workflow on pull requests #7824

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

ulgens
Copy link
Contributor

@ulgens ulgens commented Feb 20, 2025

Enables precommit_checks CI workflow on pull requests, so PRs with issues will be automatically detected during review process.

Relates to

@ulgens ulgens changed the title Enable pre-commit CI workflow on pull requests fix: Enable pre-commit CI workflow on pull requests Feb 20, 2025
@ulgens
Copy link
Contributor Author

ulgens commented Feb 20, 2025

I updated the detail but I'm not allowed to rerun the pipeline. Even though that step succeeds, I expect another failure from the actual pre-commit step.

@okhat
Copy link
Collaborator

okhat commented Feb 20, 2025

Thanks so much @ulgens ! Should I merge this now? Or do you want to follow up with a different PR first?

@ulgens
Copy link
Contributor Author

ulgens commented Feb 20, 2025

@okhat I'd like to apply fixes with several different PRs if that's okay. I don't really want to push a PR with 338 changed files.

@okhat
Copy link
Collaborator

okhat commented Feb 20, 2025

Yes that sounds good to me. But what's your plan? Should we merge this now or wait for other followups?

@ulgens
Copy link
Contributor Author

ulgens commented Feb 20, 2025

Let's merge this one.

@okhat
Copy link
Collaborator

okhat commented Feb 20, 2025

And then?

@ulgens ulgens force-pushed the run_precommit_on_PRs branch from ab9d916 to 4961ab0 Compare February 20, 2025 18:50
@ulgens
Copy link
Contributor Author

ulgens commented Feb 20, 2025

Then, I'm planning to create PRs like these

for each hook repos under pre-commit, and finally enable everything, optimize the pre-commit workflow and make it faster.

@ulgens ulgens mentioned this pull request Feb 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants