-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Enable pre-commit CI workflow on pull requests #7824
base: main
Are you sure you want to change the base?
Conversation
I updated the detail but I'm not allowed to rerun the pipeline. Even though that step succeeds, I expect another failure from the actual pre-commit step. |
Thanks so much @ulgens ! Should I merge this now? Or do you want to follow up with a different PR first? |
@okhat I'd like to apply fixes with several different PRs if that's okay. I don't really want to push a PR with 338 changed files. |
Yes that sounds good to me. But what's your plan? Should we merge this now or wait for other followups? |
Let's merge this one. |
And then? |
66fdae7
to
ab9d916
Compare
ab9d916
to
4961ab0
Compare
Then, I'm planning to create PRs like these for each hook repos under pre-commit, and finally enable everything, optimize the pre-commit workflow and make it faster. |
Enables
precommit_checks
CI workflow on pull requests, so PRs with issues will be automatically detected during review process.Relates to