Use legacy module missing code “MODULE_NOT_FOUND” for cjs. [closes #206]

standard-things · Jan 3, 2018 · 96d4ca4 · 96d4ca4
1 parent ce81a9b
commit 96d4ca4
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 3 deletions.
diff --git a/src/module/cjs/_resolve-filename.js b/src/module/cjs/_resolve-filename.js
@@ -1,7 +1,7 @@
 import _resolveFilename from "../_resolve-filename.js"
-import errors from "../../errors.js"
 import getModuleName from "../../util/get-module-name.js"
 import shared from "../../shared.js"
+import toStringLiteral from "../../util/to-string-literal.js"
 
 function resolveFilename(id, parent, isMain) {
   const cacheKey = id + "\0" + getModuleName(parent) + "\0" + isMain
@@ -16,7 +16,9 @@ function resolveFilename(id, parent, isMain) {
     return shared.resolveFilename[cacheKey] = filePath
   }
 
-  throw new errors.Error("ERR_MISSING_MODULE", id)
+  const error = new Error("Cannot find module '" + toStringLiteral(id) + "'")
+  error.code = "MODULE_NOT_FOUND"
+  throw error
 }
 
 export default resolveFilename
diff --git a/test/main-hook-tests.mjs b/test/main-hook-tests.mjs
@@ -125,7 +125,14 @@ describe("module.runMain hook", function () {
       .reduce((promise, args) =>
         promise
           .then(() => node(args))
-          .then((result) => assert.ok(result.stderr.includes("ERR_MISSING_MODULE")))
+          .then((result) => {
+            const fileName = args[2]
+            const code = fileName.endsWith(".mjs")
+              ? "ERR_MISSING_MODULE"
+              : "MODULE_NOT_FOUND"
+
+            assert.ok(result.stderr.includes(code))
+          })
       , Promise.resolve())
   })
 })