Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove anything deprecated for 1.0 release #409

Open
jgabry opened this issue Dec 16, 2020 · 1 comment · May be fixed by #1061
Open

Remove anything deprecated for 1.0 release #409

jgabry opened this issue Dec 16, 2020 · 1 comment · May be fixed by #1061
Assignees
Labels
internal-code Tests, code cleanup, refactoring, or other things not user facing

Comments

@jgabry
Copy link
Member

jgabry commented Dec 16, 2020

Just opening this so I can add it to the v1.0.0 milestone. There are many deprecated arguments we should remove in v1.0.0. (Alternatively, since we're still in beta we could just remove them in a future beta release since we've already done several beta releases keeping the deprecated arguments.)

@jgabry jgabry added the internal-code Tests, code cleanup, refactoring, or other things not user facing label Dec 16, 2020
@jgabry jgabry added this to the v1.0.0 - release milestone Dec 16, 2020
@jgabry
Copy link
Member Author

jgabry commented Jun 18, 2021

Once #520 is merged we'll also need to remove support for using old .cmdstanr directory instead of .cmdstan. Removing this would entail removing the old argument to cmdstan_default_path() and cmdstan_default_install_path and removing the use of cmdstan_default_path(old = TRUE) from zzz.R and from set_cmdstan_path().

@jgabry jgabry changed the title Remove deprecated arguments for 1.0 release Remove anything deprecated for 1.0 release Jun 18, 2021
@jgabry jgabry self-assigned this Nov 12, 2021
jgabry added a commit that referenced this issue Feb 12, 2025
@jgabry jgabry linked a pull request Feb 12, 2025 that will close this issue
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal-code Tests, code cleanup, refactoring, or other things not user facing
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant