feat(addListener): throw an error if next, error or complete functions are missing #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s are missing This class of error is a compiler error in TypeScript, but is a runtime error in JS. Currently we get an error like "this._n is not a function" which is quite cryptic to an end user.
Here's a dirty trick I sometimes use: var listener = <Listener<T>> <any> incompleteListener;👯 |
|
Does this mean that the end-user won't be able to subscribe to a stream without providing _all_ 3 functions (onNext, onError, onCompleted)? |
|
That is correct, and is in fact by design. See #1. |
|
@Widdershin thanks for clearing it up. |
done.fail isn't a thing, but if you call done with any value it will treat it as an error, so this works just fine.
Widdershin
force-pushed
the
helpful-errors
branch
from
ce4f953 to
a5d606b
Compare
|
@staltz fixed the failures (which were the result of done.fail being undefined) and added some tests for these errors. I feel like this should be good to merge 😺 |
Widdershin
force-pushed
the
helpful-errors
branch
from
2534f35 to
74282d2
Compare
|
👍 |
|
Merged as of 10721b6, thanks @Widdershin. I ended up trimming down the code, for size. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This class of error is a compiler error in TypeScript, but is a runtime error in JS. Currently we get an error like "this._n is not a function" which is quite cryptic to an end user.
I would add a test for this, but since it's a compiler error in TS I can't see any way to do so.