Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Errors should be thrown if no listeners are attached #121

Closed
kay-is opened this issue Sep 20, 2016 · 0 comments
Closed

Errors should be thrown if no listeners are attached #121

kay-is opened this issue Sep 20, 2016 · 0 comments
Labels
issue is bug weight 1 (maybe)

Comments

@kay-is
Copy link
Contributor

kay-is commented Sep 20, 2016

Steam.prototype._e swallows errors if no Listener is attached.

It should probably just re-throw the received error, if it can't pass it on.
@kay-is kay-is mentioned this issue Sep 20, 2016
Closed
staltz pushed a commit that referenced this issue Nov 25, 2016
@kay-is @staltz
Throw error if no listener is attached #121
f7e598f
staltz pushed a commit that referenced this issue Nov 28, 2016
@kay-is @staltz
fix(stream): throw error when there are no error listeners
e512c3e 
If an error is being propagated in a chain of streams and the current
stream has no listeners attached, xstream would previously silently
swallow the error. This allowed for buggy behavior to pass by silently.
This commit changes the Stream implementation to check, during error
propagation in a chain of stream, whether there are
no listeners attached and simply throw the error in that case.

BREAKING CHANGE:
![maybe
will](https://img.shields.io/badge/will%20it%20affect%20me%3F-maybe%20will-yellow.svg)
This changes the behavior of most xstream code because errors are no
longer swallowed. When you update xstream to this version, you may
experience new errors thrown that you haven't seen before. Upgrade
carefully, keeping in mind that these thrown errors were always there,
but only now are surfaced.

Closes issue #121
@staltz staltz closed this as completed Nov 28, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
issue is bug weight 1 (maybe)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@staltz @kay-is