Skip to content
This repository has been archived by the owner on Dec 18, 2019. It is now read-only.

pickMerge throws error if child is not using sink #58

Closed
jvanbruegge opened this issue Oct 25, 2017 · 1 comment
Closed

pickMerge throws error if child is not using sink #58

jvanbruegge opened this issue Oct 25, 2017 · 1 comment
Labels
bug

Comments

@jvanbruegge
Copy link
Contributor

If you have a child that is e.g. not using HTTP, and you try

collectSinks: instances => ({
    HTTP: instances.pickMerge('HTTP')
})

onionify makeCollection just throws an error. It would make sense to just return xs.never()
@staltz
Copy link
Owner

staltz commented Oct 25, 2017

I agree.

@staltz staltz added the bug label Oct 25, 2017
jvanbruegge added a commit to jvanbruegge/cycle-onionify that referenced this issue Jun 7, 2018
@jvanbruegge
Add test for staltz#58
26bbeca
jvanbruegge added a commit to jvanbruegge/cycle-onionify that referenced this issue Jun 7, 2018
@jvanbruegge
Fix staltz#58
5435f83
staltz pushed a commit that referenced this issue Jun 7, 2018
@jvanbruegge @staltz
Add test for #58
4577b04
@staltz staltz closed this as completed in d2461fc Jun 7, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@staltz @jvanbruegge