update type definitions moving from permittedFields* to accessibleFie… #117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @bagofjuice Thanks for contribution! Could you please expose Update: sorry for the delay, currently very busy. Plan to work more actively on CASL starting from November |
…sibleFields*" This reverts commit 22ad358.
…com:bagofjuice/casl into bagofjuice/fix-typings-use-accessibleFields * 'bagofjuice/fix-typings-use-accessibleFields' of github.com:bagofjuice/casl: update type definitions moving from permittedFields* to accessibleFields*
Codecov Report
@@ Coverage Diff @@
## master #117 +/- ##
=======================================
Coverage 98.07% 98.07%
=======================================
Files 16 16
Lines 311 311
=======================================
Hits 305 305
Misses 6 6Continue to review full report at Codecov.
|
|
PR updated to expose accessibleFieldsBy together with permittedFieldsBy. |
|
Looks good now. I’ll publish a new version in 4 hours. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…lds*