fix(ability): makes sure error for wrong Ability usage is thrown

Relates to #334
stalniy · Jun 2, 2020 · db62daf · db62daf
1 parent 2802cec
commit db62daf
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/packages/casl-ability/src/PureAbility.ts b/packages/casl-ability/src/PureAbility.ts
@@ -197,12 +197,12 @@ export class PureAbility<A extends Abilities = Abilities, Conditions = unknown>
     const [action, subject, field] = args;
     const rules: Rule<A, Conditions>[] = (this as any).possibleRulesFor(action, subject);
 
-    if (!this._hasPerFieldRules) {
-      return rules;
+    if (field && typeof field !== 'string') {
+      throw new Error('The 3rd, `field` parameter is expected to be a string. See https://stalniy.github.io/casl/en/api/casl-ability#can-of-pure-ability for details');
     }
 
-    if (field && typeof field !== 'string') {
-      throw new Error('3rd, `field` parameter is expected to be a string. See https://stalniy.github.io/casl/en/api/casl-ability#can-of-pure-ability for details');
+    if (!this._hasPerFieldRules) {
+      return rules;
     }
 
     return rules.filter(rule => rule.matchesField(field));