Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added kotlin decode test & removed unsupported date-time #8

Merged
merged 1 commit into from
Aug 7, 2024

Conversation

Archdoog
Copy link
Collaborator

@Archdoog Archdoog commented Aug 7, 2024

This should be a bit better. Actually got a working kotlin moshi adapter test 🎉

  • Comments out date-time because it requires a special moshi adapter that swagger codegen doesn't handle. While this makes the swift a bit crappier, it seems like a low use/cost trade off for easy kotlin usage.
  • Adds decoder test from route asset.

@Archdoog Archdoog self-assigned this Aug 7, 2024
@Archdoog Archdoog requested a review from ianthetechie August 7, 2024 03:17
geometry_index:
type: number
type: integer
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call ;)

@@ -31,7 +31,7 @@ components:
type: string
data_version:
type: string
format: date-time
# format: date-time # TODO: Disabled because of missing swagger codegen kotlin adapter
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is really annoying but oh well. We can revisit later.

@ianthetechie ianthetechie merged commit 232917c into main Aug 7, 2024
3 checks passed
@ianthetechie ianthetechie deleted the fix/via-waypoint-2 branch August 7, 2024 05:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants