Recalculation gating #453
Merged
Recalculation gating #453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @ben-burwood |
|
Funnily enough this is the exact thing I have been trialling in our app since we fell into that spiral last week! So definitely support this functionality being included in the SDK. Implementation as you have here looks good 👍 |
|
This is also likely part of the problem with #452. Many rapid re-routes blowing up the TTS queue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new gate to prevent spurious recalculations. We'll avoid recalculating unless the user has moved by at least 50m (configurable threshold) from the last point that we triggered a recalculation