Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add versioned and backwards-compatible server version to block proposal #5803

Merged
merged 6 commits into from
Feb 10, 2025
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,8 @@ and this project adheres to the versioning scheme outlined in the [README.md](RE

### Added

- The `BlockProposal` StackerDB message serialization struct now includes a `server_version` string, which represents the version of the node that the mienr is using. ([#5803](https://github.com/stacks-network/stacks-core/pull/5803))
hstove marked this conversation as resolved.
Show resolved Hide resolved

### Changed

### Fixed
Expand Down
2 changes: 0 additions & 2 deletions libsigner/src/events.rs
Original file line number Diff line number Diff line change
Expand Up @@ -141,7 +141,6 @@ impl BlockProposalData {
/// Serialize the "inner" block response data. Used to determine the bytes length of the serialized block response data
fn inner_consensus_serialize<W: Write>(&self, fd: &mut W) -> Result<(), CodecError> {
write_next(fd, &self.server_version.as_bytes().to_vec())?;
// write_next(fd, &self.unknown_bytes)?;
fd.write_all(&self.unknown_bytes)
.map_err(CodecError::WriteError)?;
Ok(())
Expand Down Expand Up @@ -708,7 +707,6 @@ mod tests {
old_block_proposal.reward_cycle,
new_block_proposal.reward_cycle
);
// assert_eq!();
}

#[test]
Expand Down
1 change: 0 additions & 1 deletion libsigner/src/v0/messages.rs
Original file line number Diff line number Diff line change
Expand Up @@ -828,7 +828,6 @@ impl BlockResponseData {
/// Serialize the "inner" block response data. Used to determine the bytes length of the serialized block response data
fn inner_consensus_serialize<W: Write>(&self, fd: &mut W) -> Result<(), CodecError> {
write_next(fd, &self.tenure_extend_timestamp)?;
// write_next(fd, &self.unknown_bytes)?;
fd.write_all(&self.unknown_bytes)
.map_err(CodecError::WriteError)?;
Ok(())
Expand Down