Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: extend the default block_proposal_timeout to 4 hours #5768

Merged
merged 8 commits into from
Feb 5, 2025
Merged

chore: extend the default block_proposal_timeout to 4 hours #5768

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
9851a24
chore: extend the default `block_proposal_timeout` to 4 hours
obycode Jan 29, 2025
6d9441c
Merge branch 'develop' into long-block-proposal-timeout
hstove Jan 30, 2025
38dbdcd
test: fix flakiness in `tests::nakamoto_integrations::skip_mining_lon…
obycode Jan 30, 2025
6224b72
test: increase timeout in `block_validation_pending_table`
obycode Jan 30, 2025
f3f49a4
Merge branch 'develop' into long-block-proposal-timeout
obycode Jan 30, 2025
fa6a6b7
refactor: add `check_nakamoto_no_missing_blocks` func
obycode Jan 31, 2025
8641730
Merge branch 'develop' into long-block-proposal-timeout
kantai Feb 4, 2025
f465d80
Merge branch 'develop' into long-block-proposal-timeout
obycode Feb 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions stacks-signer/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,12 @@ All notable changes to this project will be documented in this file.
The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
and this project adheres to the versioning scheme outlined in the [README.md](README.md).

## [Unreleased]

### Changed

- Increase default `block_proposal_timeout_ms` from 10 minutes to 4 hours. Until #5729 is implemented, there is no value in rejecting a late block from a miner, since a late block is better than no block at all.

## [3.1.0.0.4.0]

## Added
Expand Down
2 changes: 1 addition & 1 deletion stacks-signer/src/config.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ use stacks_common::util::hash::Hash160;
use crate::client::SignerSlotID;

const EVENT_TIMEOUT_MS: u64 = 5000;
const BLOCK_PROPOSAL_TIMEOUT_MS: u64 = 600_000;
const BLOCK_PROPOSAL_TIMEOUT_MS: u64 = 14_400_000;
const BLOCK_PROPOSAL_VALIDATION_TIMEOUT_MS: u64 = 120_000;
const DEFAULT_FIRST_PROPOSAL_BURN_BLOCK_TIMING_SECS: u64 = 60;
const DEFAULT_TENURE_LAST_BLOCK_PROPOSAL_TIMEOUT_SECS: u64 = 30;
Expand Down