Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: cargo clippy-stacks errors #5746

Merged
merged 1 commit into from
Jan 27, 2025

Conversation

jbencin
Copy link
Contributor

@jbencin jbencin commented Jan 25, 2025

Description

Fix new errors in cargo clippy-stacks introduced by #5739

Since we just added cargo clippy-stacks to CI, it's important we keep this working so people don't end up ignoring and dismissing it as a broken test

Applicable issues

@jbencin jbencin requested a review from a team as a code owner January 25, 2025 02:02
@jbencin jbencin added the lint Related to linting/clippy/cargo warns label Jan 25, 2025
@jbencin jbencin force-pushed the fix/clippy-stacks-errors branch from b93da65 to 1415732 Compare January 25, 2025 02:10
Copy link
Contributor

@obycode obycode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jbencin jbencin added this pull request to the merge queue Jan 27, 2025
Merged via the queue into stacks-network:develop with commit a5a6ce6 Jan 27, 2025
2 checks passed
@jbencin jbencin deleted the fix/clippy-stacks-errors branch January 27, 2025 19:35
@blockstack-devops
Copy link
Contributor

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@stacks-network stacks-network locked as resolved and limited conversation to collaborators Feb 4, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lint Related to linting/clippy/cargo warns locked
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants