chore: Apply Clippy lints single_match and redundant_pattern_matching
#5740
+680
−1,053
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
obycode
previously approved these changes
Jan 23, 2025
kantai
reviewed
Jan 24, 2025
kantai
reviewed
Jan 24, 2025
…pattern-matching` and fix conflicts
obycode
previously approved these changes
Jan 24, 2025
kantai
reviewed
Jan 24, 2025
kantai
previously approved these changes
Jan 24, 2025
jferrant
reviewed
Jan 24, 2025
obycode
reviewed
Jan 27, 2025
There was a problem hiding this comment.
Looks good. I just triggered a retry of the failing tests.
- tests::nakamoto_integrations::follower_bootup_across_multiple_cycles
- tests::signer::v0::no_reorg_due_to_successive_block_validation_ok
- tests::signer::v0::single_miner_empty_sortition
- net::tests::convergence::test_walk_star_allowed_15
- net::tests::convergence::test_walk_star_15_plain
…attern-matching and fix conflicts
obycode
previously approved these changes
Jan 28, 2025
jferrant
previously approved these changes
Jan 29, 2025
…pattern-matching` and fix conflicts
|
Quick review of failing tests:
|
obycode
approved these changes
Jan 31, 2025
jferrant
approved these changes
Feb 1, 2025
Merged
via the queue into
stacks-network:develop
with commit Feb 1, 2025
d2ed454
175 of 181 checks passed
jbencin
deleted the
chore/clippy-single-match-and-redundant-pattern-matching
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Apply the following Clippy lints:
single_matchredundant_pattern_matchingThese lints reduce certain
matchandif letstatements into simpler forms, and result in 370 fewer lines of code