Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Allow stacks-inspect try-mine to mine multiple blocks #5688

Draft
wants to merge 4 commits into
base: develop
Choose a base branch
from
Draft

feat: Allow stacks-inspect try-mine to mine multiple blocks #5688

wants to merge 4 commits into from

Conversation

jbencin
Copy link
Contributor

@jbencin jbencin commented Jan 13, 2025 •
edited
Loading

Description

Add--max-blocks <x> argument to stacks-inspect try-mine to allow it to mine either until the mempool is empty or x blocks have been mined

Applicable issues

Additional info (benefits, drawbacks, caveats)

Checklist

  • Test coverage for new or modified code paths
  • Changelog is updated
  • Required documentation changes (e.g., docs/rpc/openapi.yaml and rpc-endpoints.md for v2 endpoints, event-dispatcher.md for new events)
  • New clarity functions have corresponding PR in clarity-benchmarking repo
  • New integration test(s) added to bitcoin-tests.yml

@jbencin jbencin force-pushed the feat/try-mine-multiple-blocks branch from f95f21f to 3a48f03 Compare January 14, 2025 15:10
@jbencin jbencin marked this pull request as ready for review January 14, 2025 15:10
@jbencin jbencin requested a review from a team as a code owner January 14, 2025 15:10
@jbencin jbencin requested a review from obycode January 14, 2025 15:10
@obycode
Copy link
Contributor

obycode commented Jan 14, 2025

Trying this out with --max-blocks 3, I see it only mining three blocks with just the tenure extend transaction.

@jbencin
Copy link
Contributor Author

jbencin commented Jan 16, 2025

I took a closer look at this and it's filling the blocks for me, but mining the same transactions repeatedly. Moving this back to draft

@jbencin jbencin marked this pull request as draft January 16, 2025 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@obycode obycode Awaiting requested review from obycode

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jbencin @obycode