chore: log if metrics_endpoint but no feature flag #5279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice, now that @wileyj updated the test runner to use the |
kantai
previously approved these changes
Oct 7, 2024
jcnelson
previously approved these changes
Oct 7, 2024
obycode
previously approved these changes
Oct 7, 2024
Merged
obycode
reviewed
Oct 14, 2024
jferrant
previously approved these changes
Oct 21, 2024
|
simple_neon_integration test seems to be broken and I think by this...it is complaining I think about a metrics response not existing as expected. |
jcnelson
reviewed
Oct 21, 2024
jferrant
approved these changes
Nov 8, 2024
obycode
approved these changes
Nov 9, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When calling
start_server_monitoring_metrics, there is an inverse feature flag (not(features = "monitoring_prom")) and log if you've setmetrics_endpointbut don't have--feature monitoring_prom. This is helpful in the case that you're trying to setup monitoring, and added the config field, but didn't add the feature flag.This log wasn't getting shown because
start_server_monitoring_metricswas itself behind a feature flag, so the log never showed up. This PR changes this to always callstart_server_monitoring_metrics- it's still a no-op (with just the log mentioned) if the feature flag isn't provided.