Feat: added mining-related prometheus stats #2664
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcnelson
reviewed
May 19, 2021
jcnelson
reviewed
May 19, 2021
jcnelson
reviewed
May 19, 2021
jcnelson
reviewed
May 19, 2021
…ange in consensus crit code, use lazy_static instead of unsafe block
kantai
reviewed
May 20, 2021
…iner metric code into prometheus feature blocks
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #2651
Added the following metrics in prometheus:
The latter two metrics are u128 values. Prometheus's IntGauge only captures 64 bit values, so I used two IntGauges for both of the metrics (one for the high 64 bits, and another for the low 64 bits).
Type of Change
Testing information
Ran
BITCOIND_TEST=1 cargo test --release --features monitoring_prom -- --test-threads 1 --ignored neon_integrations::bitcoind_integration_testin thetestnet/stacks-nodedirectory. Pinged the prometheus endpoint and got the value of all tracked metrics, which I then checked against expected value.Ran
cargo test.