Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Added event for new microblocks #2571

Merged
merged 13 commits into from
Apr 27, 2021
Merged

Conversation

pavitthrap
Copy link
Contributor

@pavitthrap pavitthrap commented Apr 5, 2021

Description

Added events for unconfirmed microblocks for issue #2553. The event data includes the index_block_hash of the preceding block, filtered events (only includes the events from the receipts that each event observer is interested in), and transaction receipts.

Each payload may contain transactions from multiple microblocks. Each tx receipt comes with a tx_index, which starts from 0 for each microblock. Each tx receipt also includes the sequence number of the microblock it belongs to.

Notes

  • One foreseeable "issue" is that different stacks nodes might have different microblock streams (in the case the leader is creating a microblock fork). If someone is querying the API through a load balancer endpoint, the load balancer could conceivably direct a user to different stacks nodes on each page refresh, which could lead to different data on the page. This might not be an important case to consider if most leaders are acting honestly, but something to consider.
  • I could add more in-depth testing

Type of Change

  • New feature
  • Bug fix
  • API reference/documentation update
  • Other

Testing information

Ran microblock_integration_test in neon_integrations.rs. Ran cargo test.

@pavitthrap pavitthrap requested review from kantai and zone117x April 5, 2021 22:14
@pavitthrap pavitthrap marked this pull request as ready for review April 8, 2021 19:57
@pavitthrap pavitthrap marked this pull request as draft April 9, 2021 17:42
@pavitthrap pavitthrap marked this pull request as ready for review April 12, 2021 22:33
Copy link
Member

@jcnelson jcnelson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just one minor comment to address.

Copy link
Member

@kantai kantai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just needs to do some merge conflict resolution.

@blockstack-devops
Copy link
Contributor

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@stacks-network stacks-network locked as resolved and limited conversation to collaborators Nov 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants