Fix: atlas attachment serving + broken test #2390
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcnelson
reviewed
Jan 29, 2021
| @@ -387,7 +387,7 @@ impl AtlasDB { | |||
| content_hash: &Hash160, | |||
| ) -> Result<Option<Attachment>, db_error> { | |||
| let hex_content_hash = to_hex(&content_hash.0[..]); | |||
| let qry = "SELECT content, hash FROM attachments WHERE hash = ?1 AND was_instantiated = 0" | |||
| let qry = "SELECT content, hash FROM attachments WHERE hash = ?1 AND was_instantiated = 1" | |||
There was a problem hiding this comment.
There haven't been any attachments propagated to the mainnet network yet, right? i.e. We're certain this change isn't going to break anything?
There was a problem hiding this comment.
The BNS endpoints + registrar not being live at this point, the only interactions that happened with the contract were internal tests (https://explorer.stacks.co/txid/SP000000000000000000002Q6VF78.bns?chain=mainnet)
jcnelson
approved these changes
Jan 29, 2021
kantai
approved these changes
Jan 29, 2021
kantai
reviewed
Jan 29, 2021
| @@ -16,9 +16,6 @@ jobs: | |||
| DOCKER_BUILDKIT: 1 | |||
| run: docker build -f ./.github/actions/bitcoin-int-tests/Dockerfile.bitcoin-tests . | |||
| atlas-test: | |||
| # disable this job/test for now, since we haven't seen this pass | |||
| # on github actions in a while | |||
| if: ${{ false }} | |||
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After investigation, it turns out the atlas test was broken for a good reason.
namespace-preordercontract call was failing.