Use ranges when checking percentage

Signed-off-by: Jacinta Ferrant <[email protected]>
stacks-network · Nov 14, 2024 · 21ed874 · 21ed874
1 parent 804b8b9
commit 21ed874
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/stackslib/src/chainstate/nakamoto/miner.rs b/stackslib/src/chainstate/nakamoto/miner.rs
@@ -536,7 +536,7 @@ impl NakamotoBlockBuilder {
             .mempool_settings
             .tenure_cost_limit_per_block_percentage
         {
-            if percentage < 100 {
+            if (1..100).contains(&percentage) {
                 let mut remaining_limit = block_limit.clone();
                 let cost_so_far = tenure_tx.cost_so_far();
                 if remaining_limit.sub(&cost_so_far).is_ok() {

diff --git a/testnet/stacks-node/src/config.rs b/testnet/stacks-node/src/config.rs
@@ -2574,7 +2574,7 @@ impl MinerConfigFile {
         let pre_nakamoto_mock_signing = mining_key.is_some();
         let valid_tenure_cost_limit = self
             .tenure_cost_limit_per_block_percentage
-            .map(|p| p <= 100 && p > 0)
+            .map(|p| (1..=100).contains(&p))
             .unwrap_or(true);
         if !valid_tenure_cost_limit {
             return Err(