Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enable disjoint queries for kademlia #673

Merged
merged 1 commit into from
Oct 15, 2024

Conversation

cylewitruk
Copy link
Member

@cylewitruk cylewitruk commented Oct 15, 2024

Description

Enables disjoint path lookups for libp2p's Kademlia implementation (part of S/Kademlia). This is a mitigation against byzantine peers attempting confuse the network by altering data on lookups crossing their path.

This change makes nodes query multiple disjoint paths (i.e. starting at different peer nodes) concurrently and requiring a minimum allowable quorum on the result.

More information:

Changes

Enables disjoint path lookups in the Kademlia configuration for the libp2p swarm.

Checklist:

  • I have performed a self-review of my code
  • My changes generate no new warnings
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@cylewitruk cylewitruk added the sbtc signer binary The sBTC Bootstrap Signer. label Oct 15, 2024
@cylewitruk cylewitruk added this to the sBTC Release Ready milestone Oct 15, 2024
@cylewitruk cylewitruk requested a review from djordon October 15, 2024 02:16
@cylewitruk cylewitruk self-assigned this Oct 15, 2024
Copy link
Collaborator

@djordon djordon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@cylewitruk cylewitruk merged commit 0e14a6b into main Oct 15, 2024
4 checks passed
@cylewitruk cylewitruk deleted the feat/enable-disjoint-queries-for-kademlia branch October 15, 2024 03:03
@cylewitruk cylewitruk restored the feat/enable-disjoint-queries-for-kademlia branch October 15, 2024 09:17
@cylewitruk cylewitruk deleted the feat/enable-disjoint-queries-for-kademlia branch October 15, 2024 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sbtc signer binary The sBTC Bootstrap Signer.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants