-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Basic support for export PKCS8 #27
Conversation
@shea256 some updates? |
I noticed that I did the commits with a different email, so I added that email and signed the CLA. |
@kantai some news? |
@giovanni9793 the whitespace and formatting changes introduced in this PR make it difficult to review. Please revert unnecessary formatting changes and the org may have the bandwidth to review. |
@zone117x now should be ok, right? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks @giovanni9793!
Description
As a developer, I would like export the private key in PKCS #8. This is needed because some libraries accept only this format. This pull request adds the
PrivateKeyPKCS8
interface which describe the structure of PKCS #8.Type of Change
Does this introduce a breaking change?
No
Are documentation updates required?
Testing information
Tests added.
Checklist
npm run test
passes