Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: missing push notifications #1856

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Soxasora
Copy link
Member

@Soxasora Soxasora commented Jan 31, 2025

Description

Fixes #1845

It adds the following missing push notifications:

  • Territory status change
    -- on every territoryStatusUpdate and successful auto-renewal after failure, send a notification with the new status
  • Territory revenue
    -- when territoryRevenue gets executed, send a notification with values calculated in the last hour
  • Referral rewards
    -- add support for Forever Referral and One Day Referral to notifyEarner

Screenshots

Additional Context

Unsure:

  • Invoicification -- when you have to retry a payment; maybe we need a notification near invoice expiration

Not available:

Checklist

Are your changes backwards compatible? Please answer below:

On a scale of 1-10 how well and how have you QA'd this change and any features it might affect? Please answer below:

For frontend changes: Tested on mobile, light and dark mode? Please answer below:

Did you introduce any new environment variables? If so, call them out explicitly here:

Progress

  • ReferralReward
    • needs testing
  • SubStatus (territory status change)
    • GRACE: every not paid day for 5 days, the user receives a notification with a formatted due date
    • STOPPED: territory archived
    • ACTIVE: if auto-renewal is successful after a failed attempt, send 'active again' notification
  • Revenue (territory revenue)

@Soxasora Soxasora force-pushed the more_push_notifications branch from 254b27e to 5145c7f Compare February 2, 2025 06:46
@Soxasora Soxasora force-pushed the more_push_notifications branch 3 times, most recently from 7837559 to 1dd1bcc Compare February 2, 2025 14:17
@Soxasora Soxasora force-pushed the more_push_notifications branch from 1dd1bcc to 6e9be5b Compare February 2, 2025 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add missing push notifications
1 participant