fix: chat response auto scroll #1209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix for chat response auto scroll : ### Benefits - More reliable auto-scrolling during streaming - Better handling of user scroll interactions - Improved mobile device support - Smoother initial load with instant scroll - Cleaner code organization and maintainability ### Testing The changes can be verified by: 1. Loading chat - should instantly scroll to bottom 2. Streaming messages - should smoothly auto-scroll 3. Manual scroll up - should stay at user's position 4. Scroll to bottom - should resume auto-scroll 5. Mobile testing - should work with touch interactions
Stijnus
changed the title
|
this feature is already present in the existing codebase
in my last PR I just fixed that scroll, we can just add some additional improvement on top it instead of reimplementing it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for chat response auto scroll :
Benefits
Testing
The changes can be verified by: