Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - Microk8s compatibility #45

Closed
wants to merge 4 commits into from
Closed

[Merged by Bors] - Microk8s compatibility #45

wants to merge 4 commits into from

Conversation

nightkr
Copy link
Member

@nightkr nightkr commented Feb 3, 2023

Description

Fixes #44, see stackabletech/secret-operator#229

Review Checklist

  • Code contains useful comments
  • CRD change approved (or not applicable)
  • (Integration-)Test cases added (or not applicable)
  • Documentation added (or not applicable)
  • Changelog updated (or not applicable)
  • Cargo.toml only contains references to git tags (not specific commits or branches)
  • Helm chart can be installed and deployed operator works (or not applicable)

Once the review is done, comment bors r+ (or bors merge) to merge. Further information

@nightkr nightkr marked this pull request as ready for review February 3, 2023 11:17
@nightkr nightkr requested a review from a team February 3, 2023 11:17
sbernauer
sbernauer approved these changes Feb 3, 2023
View reviewed changes
Copy link
Member

@sbernauer sbernauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx!

@nightkr
Copy link
Member Author

nightkr commented Feb 3, 2023

bors r+

bors bot pushed a commit that referenced this pull request Feb 3, 2023
@nightkr
Microk8s compatibility (#45)
9e4e11d 
# Description

Fixes #44, see stackabletech/secret-operator#229
@bors
Copy link

bors bot commented Feb 3, 2023

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Microk8s compatibility [Merged by Bors] - Microk8s compatibility Feb 3, 2023
@bors bors bot closed this Feb 3, 2023
@bors bors bot deleted the bugfix/microk8s branch February 3, 2023 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbernauer sbernauer sbernauer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support microk8s
2 participants
@nightkr @sbernauer