Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support non-default cluster domain #237

Merged
merged 7 commits into from
Oct 23, 2024

linter

66357c7
Select commit
Loading
Failed to load commit list.
Sign in for the full log view
Merged

feat: Support non-default cluster domain #237

linter
66357c7
Select commit
Loading
Failed to load commit list.
GitHub Actions / LanguageTool succeeded Oct 23, 2024 in 0s

reviewdog [LanguageTool] report

reported by reviewdog 🐶

Findings (0)
Filtered Findings (13)

.github/PULL_REQUEST_TEMPLATE/pre-release-getting-started-script.md|4 col 45| The official name of this software platform is spelled with a capital “H”. (GITHUB[1])
Suggestions: GitHub
URL: https://en.wikipedia.org/wiki/GitHub
Rule: https://community.languagetool.org/rule/show/GITHUB?lang=en-US&subId=1
Category: CASING
.github/PULL_REQUEST_TEMPLATE/pre-release-rust-deps.md|4 col 45| The official name of this software platform is spelled with a capital “H”. (GITHUB[1])
Suggestions: GitHub
URL: https://en.wikipedia.org/wiki/GitHub
Rule: https://community.languagetool.org/rule/show/GITHUB?lang=en-US&subId=1
Category: CASING
.github/pull_request_template.md|16 col 36| This expression is normally spelled as one or with a hyphen. (EN_COMPOUNDS_NON_TRIVIAL)
Suggestions: non-trivial, nontrivial
Rule: https://community.languagetool.org/rule/show/EN_COMPOUNDS_NON_TRIVIAL?lang=en-US
Category: MISC
BUILDING.md|26 col 17| Unpaired symbol: ‘"’ seems to be missing (EN_UNPAIRED_QUOTES)
URL: https://languagetool.org/insights/post/punctuation-guide/#what-are-parentheses
Rule: https://community.languagetool.org/rule/show/EN_UNPAIRED_QUOTES?lang=en-US
Category: PUNCTUATION
BUILDING.md|48 col 8| If a new sentence starts here, add a space and start with an uppercase letter. (LC_AFTER_PERIOD[1])
Suggestions: Lock, lock
Rule: https://community.languagetool.org/rule/show/LC_AFTER_PERIOD?lang=en-US&subId=1
Category: CASING
CHANGELOG.md|51 col 83| Two determiners in a row. Choose either “a” or “an”. (DT_DT[1])
Suggestions: a, an
Rule: https://community.languagetool.org/rule/show/DT_DT?lang=en-US&subId=1
Category: GRAMMAR
README.md|63 col 19| It appears that hyphens are missing in the adjective “up-to-date”. (UP_TO_DATE_HYPHEN[2])
Suggestions: up-to-date
URL: https://languagetool.org/insights/post/hyphen/#hyphenated-phrases-with-more-than-one-hyphen
Rule: https://community.languagetool.org/rule/show/UP_TO_DATE_HYPHEN?lang=en-US&subId=2
Category: COMPOUNDING
docs/modules/listener-operator/pages/index.adoc|3 col 1| The official name of this software platform is spelled with a capital “H”. (GITHUB[1])
Suggestions: GitHub
URL: https://en.wikipedia.org/wiki/GitHub
Rule: https://community.languagetool.org/rule/show/GITHUB?lang=en-US&subId=1
Category: CASING
docs/modules/listener-operator/pages/index.adoc|7 col 3| The official name of this software platform is spelled with a capital “H”. (GITHUB[1])
Suggestions: GitHub
URL: https://en.wikipedia.org/wiki/GitHub
Rule: https://community.languagetool.org/rule/show/GITHUB?lang=en-US&subId=1
Category: CASING
docs/modules/listener-operator/pages/installation.adoc|21 col 3| Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Helm
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
docs/modules/listener-operator/pages/listenerclass.adoc|133 col 101| Generally speaking, “themself” is only acceptable when referring to a singular entity (such as the singular usage of “they”, which is the preferred pronoun for many non-binary people). If “themself” refers to a plural entity (such as “everybody”, or the standard usage of “they”), you should use “themselves”. (THEMSELF[1])
Suggestions: themselves, himself, herself
URL: https://languagetool.org/insights/post/style-singular-they/#using-singular-%E2%80%9Cthey%E2%80%9D-today
Rule: https://community.languagetool.org/rule/show/THEMSELF?lang=en-US&subId=1
Category: STYLE
docs/modules/listener-operator/pages/volume.adoc|64 col 45| Consider removing “of” to be more concise (ALL_OF_THE[1])
Suggestions: all the
URL: https://languagetool.org/insights/post/wordiness/
Rule: https://community.languagetool.org/rule/show/ALL_OF_THE?lang=en-US&subId=1
Category: REDUNDANCY
tests/README-templating.md|63 col 101| Use a comma before ‘and’ if it connects two independent clauses (unless they are closely connected and short). (COMMA_COMPOUND_SENTENCE[1])
Suggestions: , and
URL: https://languagetool.org/insights/post/types-of-sentences/#compound-sentence
Rule: https://community.languagetool.org/rule/show/COMMA_COMPOUND_SENTENCE?lang=en-US&subId=1
Category: PUNCTUATION