Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused dependencies #434

Merged
merged 1 commit into from
Jun 2, 2023
Merged

Remove unused dependencies #434

merged 1 commit into from
Jun 2, 2023

Conversation

gadomski
Copy link
Member

@gadomski gadomski commented Jun 1, 2023 •
edited
Loading

Related Issue(s):
Brought to my attention by a note in conda-forge/stactools-feedstock#10. No changlog necessary.

PR checklist:

  • Code is formatted (run scripts/format).
  • Code lints properly (run scripts/lint).
  • Tests pass (run scripts/test).
  • Documentation has been updated to reflect changes, if applicable.
  • Changes are added to the CHANGELOG.

@gadomski gadomski requested a review from jsignell June 1, 2023 20:55
@gadomski gadomski self-assigned this Jun 1, 2023
@gadomski gadomski changed the title emove unused dependencies Remove unused dependencies Jun 1, 2023
@gadomski
Copy link
Member Author

gadomski commented Jun 1, 2023

Whelp, turns out they were implicit dependencies of fsspec closing.

@gadomski gadomski closed this Jun 1, 2023
@gadomski gadomski deleted the remove-unused-requirements branch June 1, 2023 21:42
@jsignell
Copy link
Member

jsignell commented Jun 2, 2023

It looks like you could use It looks like you could use fsspec[http]>=2021.7 to pull in the extra requirements if you like

@gadomski gadomski restored the remove-unused-requirements branch June 2, 2023 12:45
@gadomski
Copy link
Member Author

gadomski commented Jun 2, 2023

That's much nicer, I'll re-open w/ that. Thank you!

@gadomski gadomski reopened this Jun 2, 2023
@gadomski gadomski force-pushed the remove-unused-requirements branch from 0a7135e to f543c8c Compare June 2, 2023 12:46
@gadomski gadomski merged commit b3d011e into main Jun 2, 2023
@gadomski gadomski deleted the remove-unused-requirements branch June 2, 2023 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsignell jsignell jsignell approved these changes

Assignees

@gadomski gadomski

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gadomski @jsignell