Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose recursive_round function #390

Merged
merged 3 commits into from
Jan 26, 2023
Merged

Expose recursive_round function #390

merged 3 commits into from
Jan 26, 2023

Conversation

pjhartzell
Copy link
Collaborator

@pjhartzell pjhartzell commented Jan 25, 2023

Related Issue(s):
None

Description:
Pulls the recursive_round() function out of round_coordinates(). Being able to access recursive_round directly is useful in cases, e.g., where you'd like to round coordinates prior to creating an Item or Collection.

PR checklist:

  • Code is formatted (run scripts/format).
  • Code lints properly (run scripts/lint).
  • Tests pass (run scripts/test).
  • Documentation has been updated to reflect changes, if applicable.
  • Changes are added to the CHANGELOG.

@pjhartzell pjhartzell requested a review from gadomski January 25, 2023 15:59
@pjhartzell
Copy link
Collaborator Author

@gadomski Does this need a changelog entry? It is just an edit to an unreleased feature (the round_coordinates utility function that operates on Items and Collections) that doesn't change the functionality of the feature.

@gadomski
Copy link
Member

Does this need a changelog entry?

It adds a new free function to the public API so I'd say yes.

@gadomski gadomski added the enhancement New feature or request label Jan 25, 2023
Copy link
Member

@gadomski gadomski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we're adding it to the public API, we should probably add some unit tests to verify its behavior.

@pjhartzell pjhartzell requested a review from gadomski January 25, 2023 23:03
@pjhartzell pjhartzell merged commit 09aaae1 into main Jan 26, 2023
@pjhartzell pjhartzell deleted the expose-coord-rounding branch January 26, 2023 01:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants