Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix antimeridian polygon winding order #278

Merged
merged 2 commits into from
Apr 12, 2022
Merged

Fix antimeridian polygon winding order #278

merged 2 commits into from
Apr 12, 2022

Conversation

gadomski
Copy link
Member

@gadomski gadomski commented Apr 12, 2022

Related Issue(s): None

Description: The polygons produced by the antimeridian utils could (were always?) wound clockwise. They should be wound counterclockwise. This fixes the problem, with unit tests.

PR checklist:

  • Code is formatted (run scripts/format).
  • Code lints properly (run scripts/lint).
  • Tests pass (run scripts/test).
  • Changes are added to the CHANGELOG.

@gadomski gadomski added the bug Something isn't working label Apr 12, 2022
@gadomski gadomski added this to the v0.3.1 milestone Apr 12, 2022
@gadomski gadomski requested a review from pjhartzell April 12, 2022 13:49
@gadomski gadomski merged commit 6d831dc into main Apr 12, 2022
@gadomski gadomski deleted the antimeridian-ccw branch April 12, 2022 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants