Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relax dependencies #228

Merged
merged 5 commits into from
Feb 14, 2022
Merged

Relax dependencies #228

merged 5 commits into from
Feb 14, 2022

Conversation

gadomski
Copy link
Member

@gadomski gadomski commented Feb 8, 2022

Related Issue(s):

Description:

  • Removes the upper bounds on our dependencies.
  • Lowers the lower bounds on our dependencies, where possible. This process was pretty unscientific, mostly just manually installing versions and running the test suite.
  • Adds minimum-versions and pre-release-versions to our CI.
  • Changes the names of the python build actions
  • Breaks python-matrix into standard and extra-requires
  • Refactors the Python setup to repository-specific composite action to reduce duplication in the workflow file

Note that we had to unset PROJ_LIB to get the pre-release to pass, as described here: https://github.com/rasterio/rasterio/blob/master/docs/faq.rst#why-cant-rasterio-find-projdb-rasterio-from-pypi-versions--120. Not quite sure the correct approach to future-proof ourselves here, so going to just leave this as the solution in lieu of a better suggestion.

PR checklist:

  • Code is formatted (run scripts/format).
  • Code lints properly (run scripts/lint).
  • Tests pass (run scripts/test).
  • Documentation has been updated to reflect changes, if applicable.
  • Changes are added to the CHANGELOG.
  • Bring "required" actions into sync with the new actions/names (will be done after approval)

@gadomski gadomski force-pushed the issues/227-relax-dependencies branch from 1c2f1df to 7d223db Compare February 8, 2022 19:51
@gadomski gadomski changed the title Issues/227 relax dependencies Relax dependencies Feb 8, 2022
@gadomski gadomski force-pushed the issues/227-relax-dependencies branch 4 times, most recently from 088e5c9 to 48e8b8e Compare February 9, 2022 12:48
Includes some ad-hoc testing to see how low we could go with some
dependencies. Also includes a requirements-min.txt file.
Until we can floor numpy at 1.22.0, we need these comments to maintain correct
typing.
@gadomski gadomski added this to the v0.3.0 milestone Feb 9, 2022
@gadomski gadomski force-pushed the issues/227-relax-dependencies branch from 48e8b8e to 8df4668 Compare February 9, 2022 12:51
@gadomski gadomski added bug Something isn't working dependencies Pull requests that update a dependency file ci Pull requests that update ci code labels Feb 9, 2022
@gadomski gadomski force-pushed the issues/227-relax-dependencies branch 14 times, most recently from 533b5cb to a8a9b81 Compare February 9, 2022 21:49
Includes a refactor of the Python setup into a repository-specific action to
reduce duplication.
Use a script to ensure the minimum requirements file is in-sync with the package.
@gadomski gadomski force-pushed the issues/227-relax-dependencies branch from 554a235 to e74bfa7 Compare February 9, 2022 21:58
gadomski added a commit that referenced this pull request Feb 9, 2022
@gadomski gadomski force-pushed the issues/227-relax-dependencies branch from e5a5f83 to d1e084f Compare February 9, 2022 22:47
@gadomski gadomski marked this pull request as ready for review February 9, 2022 22:51
Copy link
Collaborator

@TomAugspurger TomAugspurger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one minor question.

scripts/check_minimum_requirements Show resolved Hide resolved
@gadomski gadomski merged commit b16af05 into main Feb 14, 2022
@gadomski gadomski deleted the issues/227-relax-dependencies branch February 14, 2022 12:41
@gadomski gadomski mentioned this pull request Feb 15, 2022
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ci Pull requests that update ci code dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Relax upper bounds on dependencies
3 participants