-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Relax dependencies #228
Merged
Merged
Relax dependencies #228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1c2f1df
to
7d223db
Compare
088e5c9
to
48e8b8e
Compare
Includes some ad-hoc testing to see how low we could go with some dependencies. Also includes a requirements-min.txt file.
Until we can floor numpy at 1.22.0, we need these comments to maintain correct typing.
48e8b8e
to
8df4668
Compare
533b5cb
to
a8a9b81
Compare
Includes a refactor of the Python setup into a repository-specific action to reduce duplication.
Use a script to ensure the minimum requirements file is in-sync with the package.
554a235
to
e74bfa7
Compare
gadomski
added a commit
that referenced
this pull request
Feb 9, 2022
e5a5f83
to
d1e084f
Compare
TomAugspurger
approved these changes
Feb 10, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just one minor question.
duckontheweb
approved these changes
Feb 12, 2022
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
Something isn't working
ci
Pull requests that update ci code
dependencies
Pull requests that update a dependency file
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue(s):
numpy>=1.22.0
until we drop Python 3.7, and until we do we need some# type: ignore
comments on a couple of numpy calls that need to be ignored for newer numpy versions.Description:
minimum-versions
andpre-release-versions
to our CI.python-matrix
intostandard
andextra-requires
Note that we had to unset
PROJ_LIB
to get the pre-release to pass, as described here: https://github.com/rasterio/rasterio/blob/master/docs/faq.rst#why-cant-rasterio-find-projdb-rasterio-from-pypi-versions--120. Not quite sure the correct approach to future-proof ourselves here, so going to just leave this as the solution in lieu of a better suggestion.PR checklist:
scripts/format
).scripts/lint
).scripts/test
).